Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-6325

Replace BOOST_STATIC_ASSERT with static_assert

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None
    • Story Points:
      0.5
    • Sprint:
      DRP X16-3
    • Team:
      Data Release Production

      Description

      Replace BOOST_STATIC_ASSERT with static_assert from C++11.

        Attachments

          Issue Links

            Activity

            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            CI run 11698 still ongoing, but past afw which is the only package affected by the changes so I don't expect to see anything.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - CI run 11698 still ongoing, but past afw which is the only package affected by the changes so I don't expect to see anything.
            Hide
            swinbank John Swinbank added a comment -

            Looks good, thank you.

            Show
            swinbank John Swinbank added a comment - Looks good, thank you.
            Hide
            swinbank John Swinbank added a comment - - edited

            Actually, one comment – could you provide helpful error messages rather than just empty strings for when the assertion fails? For example, it's not trivially obvious to the reader why U should be const. (I realise that this goes beyond what Boost was previously providing.)

            Show
            swinbank John Swinbank added a comment - - edited Actually, one comment – could you provide helpful error messages rather than just empty strings for when the assertion fails? For example, it's not trivially obvious to the reader why U should be const . (I realise that this goes beyond what Boost was previously providing.)
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            Merged after final CI build and adding of comments.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Merged after final CI build and adding of comments.

              People

              • Assignee:
                pschella Pim Schellart [X] (Inactive)
                Reporter:
                pschella Pim Schellart [X] (Inactive)
                Reviewers:
                John Swinbank
                Watchers:
                John Swinbank, Pim Schellart [X] (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: