Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-6354

Warn/raise when input catalogs have no (few?) cross-matches

    Details

    • Story Points:
      4
    • Sprint:
      AP S19-5, AP S19-6, AP F19-1
    • Team:
      Alert Production

      Description

      jointcal should either print a large warning, or raise an exception if the input catalogs (either the N FittedStar catalogs, or the RefStar catalog) don't have any (or less than some reasonable number, say 10% of the total?) associations between each other. It currently just keeps going and then segfaults later on, likely because the fitting code can't handle that situation.

        Attachments

          Issue Links

            Activity

            Hide
            rhl Robert Lupton added a comment -

            Where is the SEGV coming from? It should just fail in Cholesky.

            A warning is OK, but it should keep going and then catch the exception (currently it returns 2 in AstromFit::Minimize)

            Show
            rhl Robert Lupton added a comment - Where is the SEGV coming from? It should just fail in Cholesky. A warning is OK, but it should keep going and then catch the exception (currently it returns 2 in AstromFit::Minimize)
            Hide
            Parejkoj John Parejko added a comment -

            Returns 2 what?

            I have not tracked down the segfault, but I can get a segfault in a variety of different ways. Making jointcal more robust so it doesn't segfault is the point of this epic. I'll have to figure out the details of why it segfaults in order to do so.

            Show
            Parejkoj John Parejko added a comment - Returns 2 what? I have not tracked down the segfault, but I can get a segfault in a variety of different ways. Making jointcal more robust so it doesn't segfault is the point of this epic. I'll have to figure out the details of why it segfaults in order to do so.
            Hide
            rhl Robert Lupton added a comment -

            I meant that the code in `AstromFit::Minimize` has a "return 2" statement.

            I realise that getting to the bottom of these problems are the point of your work on this epic, but Pierre was wondering what gdb said about at least one of the SEGVs.

            Show
            rhl Robert Lupton added a comment - I meant that the code in `AstromFit::Minimize` has a "return 2" statement. I realise that getting to the bottom of these problems are the point of your work on this epic, but Pierre was wondering what gdb said about at least one of the SEGVs.

              People

              • Assignee:
                Parejkoj John Parejko
                Reporter:
                Parejkoj John Parejko
                Watchers:
                John Parejko, Robert Lupton, Simon Krughoff
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Summary Panel