# Warn/raise when input catalogs have no (few?) cross-matches

XMLWordPrintable

## Details

• Type: Story
• Status: To Do
• Resolution: Unresolved
• Fix Version/s: None
• Component/s:
• Labels:
• Story Points:
4
• Sprint:
AP S19-5, AP S19-6, AP F19-1
• Team:

## Description

jointcal should either print a large warning, or raise an exception if the input catalogs (either the N FittedStar catalogs, or the RefStar catalog) don't have any (or less than some reasonable number, say 10% of the total?) associations between each other. It currently just keeps going and then segfaults later on, likely because the fitting code can't handle that situation.

## Activity

Hide
Robert Lupton added a comment -

Where is the SEGV coming from? It should just fail in Cholesky.

A warning is OK, but it should keep going and then catch the exception (currently it returns 2 in AstromFit::Minimize)

Show
Robert Lupton added a comment - Where is the SEGV coming from? It should just fail in Cholesky. A warning is OK, but it should keep going and then catch the exception (currently it returns 2 in AstromFit::Minimize)
Hide
John Parejko added a comment -

Returns 2 what?

I have not tracked down the segfault, but I can get a segfault in a variety of different ways. Making jointcal more robust so it doesn't segfault is the point of this epic. I'll have to figure out the details of why it segfaults in order to do so.

Show
John Parejko added a comment - Returns 2 what? I have not tracked down the segfault, but I can get a segfault in a variety of different ways. Making jointcal more robust so it doesn't segfault is the point of this epic. I'll have to figure out the details of why it segfaults in order to do so.
Hide
Robert Lupton added a comment -

I meant that the code in AstromFit::Minimize has a "return 2" statement.

I realise that getting to the bottom of these problems are the point of your work on this epic, but Pierre was wondering what gdb said about at least one of the SEGVs.

Show
Robert Lupton added a comment - I meant that the code in AstromFit::Minimize has a "return 2" statement. I realise that getting to the bottom of these problems are the point of your work on this epic, but Pierre was wondering what gdb said about at least one of the SEGVs.

## People

• Assignee:
John Parejko
Reporter:
John Parejko
Watchers:
John Parejko, Robert Lupton, Simon Krughoff