Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-6355

Raise exception when input catalog WCS is badly formed

    Details

    • Type: Story
    • Status: To Do
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: jointcal
    • Labels:
      None

      Description

      jointcal should raise an exception if the input WCS info associated with a catalog is badly formed. It currently always attempts to determine the inverse WCS via gtransfo and can fail with: trying to invert a singular transformation: a (nice) crash follows. It should stop before that and say something more about what the actual problem was.

        Attachments

          Issue Links

            Activity

            Hide
            rhl Robert Lupton added a comment -

            Does, "a nice crash" mean throws an exception? At which line?

            Show
            rhl Robert Lupton added a comment - Does, "a nice crash" mean throws an exception? At which line?
            Hide
            Parejkoj John Parejko added a comment -

            That is the error message verbatim. No exception is raised.

            Show
            Parejkoj John Parejko added a comment - That is the error message verbatim. No exception is raised.
            Hide
            rhl Robert Lupton added a comment -

            OK, thanks. I was hoping it was the message from an exception.

            Show
            rhl Robert Lupton added a comment - OK, thanks. I was hoping it was the message from an exception.
            Hide
            swinbank John Swinbank added a comment -

            John Parejko — I see the message about a “nice crash” is gone from current Jointcal, but it's not immediately obvious to me whether the rest of this issue is still current. Is it?

            Show
            swinbank John Swinbank added a comment - John Parejko — I see the message about a “nice crash” is gone from current Jointcal, but it's not immediately obvious to me whether the rest of this issue is still current. Is it?
            Hide
            Parejkoj John Parejko added a comment -

            No, this isn't fixed yet. See the # TODO a the start of JointcalTask._do_load_refcat_and_fit which is directly relevant to this. The error message was cleaned up, but we still need to figure out how to determine whether an input WCS is coherent (or whether we should check for that at all?).

            Show
            Parejkoj John Parejko added a comment - No, this isn't fixed yet. See the # TODO a the start of JointcalTask._do_load_refcat_and_fit which is directly relevant to this. The error message was cleaned up, but we still need to figure out how to determine whether an input WCS is coherent (or whether we should check for that at all?).

              People

              • Assignee:
                Parejkoj John Parejko
                Reporter:
                Parejkoj John Parejko
                Watchers:
                John Parejko, John Swinbank, Robert Lupton, Simon Krughoff
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Summary Panel