Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-6391

afw display needs to be able to display a catalog

    XMLWordPrintable

Details

    • Improvement
    • Status: Done
    • Resolution: Done
    • None
    • afw

    Description

      afw.display has to display points one at a time via:

      for pt in sourceCat:
          display.dot('o',pt.getX(),pt.getY())
      

      This is silly. I should be able to say display.showCatalog(sourceCat, coords='radec') or display.showCatalog(sourceCat, coords='cartesian') (or something) and get the catalog displayed in an appropriate manner.

      Attachments

        Issue Links

          Activity

            gpdf: I don't think this does anything that is specific to ds9: it just calls `dot()` in a loop, which firefly should already support.

            Parejkoj John Parejko added a comment - gpdf : I don't think this does anything that is specific to ds9: it just calls `dot()` in a loop, which firefly should already support.

            price: I updated the code to use buffering, which makes it quite a lot faster.

            jbosch: do you mind reviewing the pipelines docs PR? I realized that we had some user docs referring to plotting points on an image, and those would be much simpler if they just used the new code here.

            https://github.com/lsst/pipelines_lsst_io/pull/290

            Parejkoj John Parejko added a comment - price : I updated the code to use buffering, which makes it quite a lot faster. jbosch : do you mind reviewing the pipelines docs PR? I realized that we had some user docs referring to plotting points on an image, and those would be much simpler if they just used the new code here. https://github.com/lsst/pipelines_lsst_io/pull/290

            Ah, OK. As I said, I hadn't looked at the implementation yet.

            That will work, I'm sure,

            but one of the points of having this method was to allow a much better UX in Firefly, which can accept the whole catalog in a single operation and then display it as a catalog in addition to the image overlay.

            gpdf Gregory Dubois-Felsmann added a comment - Ah, OK. As I said, I hadn't looked at the implementation yet. That will work, I'm sure, but one of the points of having this method was to allow a much better UX in Firefly, which can accept the whole catalog in a single operation and then display it as a catalog in addition to the image overlay.

            Somehow the Jira "Development" widget above is not picking up the actual afw PR for this ticket: https://github.com/lsst/afw/pull/723

            gpdf Gregory Dubois-Felsmann added a comment - Somehow the Jira "Development" widget above is not picking up the actual afw PR for this ticket: https://github.com/lsst/afw/pull/723
            jbosch Jim Bosch added a comment -

            Docs look fine to me.  Not sure if I'm the last reviewer overall; please feel free to consider this reviewed if I was.

            jbosch Jim Bosch added a comment - Docs look fine to me.  Not sure if I'm the last reviewer overall; please feel free to consider this reviewed if I was.

            People

              Parejkoj John Parejko
              Parejkoj John Parejko
              Jim Bosch
              David Shupe, Gregory Dubois-Felsmann, Ian Sullivan, Jim Bosch, John Parejko, Paul Price, Robert Lupton, Tim Jenness
              Votes:
              1 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.