Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-6513

Remove unsused "version.h" file and associated code

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Qserv
    • Labels:
      None
    • Story Points:
      0.25
    • Sprint:
      DB_F19_10, DB_S20_12, DB_S20_01, DB_S20_02
    • Team:
      Data Access and Database
    • Urgent?:
      No

      Description

      This code seems obsolete and unused:

      qserv@clrinfopc04:~/src/qserv (tickets/DM-5967)$ grep -r "version.h" *
      admin/tools/docker/git/src/qserv/site_scons/genversion.py:# genversion.py : declare a builder for global version headers.
      admin/tools/docker/git/src/qserv/site_scons/genversion.py:    """Construct a version header from git-describe output and store
      admin/tools/docker/git/src/qserv/core/modules/SConscript:versionFile = env.Command(['global/version.h'], None, genversion.buildVersionHeader)
      core/modules/SConscript:versionFile = env.Command(['global/version.h'], None, genversion.buildVersionHeader)
      

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            This code still exists so I assume this ticket is still valid.

            Show
            tjenness Tim Jenness added a comment - This code still exists so I assume this ticket is still valid.
            Hide
            fritzm Fritz Mueller added a comment -

            old, trivial, ticket unearthed by the CCB: remove some unused git version plumbing

            Show
            fritzm Fritz Mueller added a comment - old, trivial, ticket unearthed by the CCB: remove some unused git version plumbing
            Hide
            jgates John Gates added a comment -

            It looks fine to me.

            Show
            jgates John Gates added a comment - It looks fine to me.

              People

              • Assignee:
                fritzm Fritz Mueller
                Reporter:
                jammes Fabrice Jammes
                Reviewers:
                John Gates
                Watchers:
                Fritz Mueller, John Gates, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel