Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ip_isr
-
Labels:
-
Story Points:1
-
Epic Link:
-
Sprint:Alert Production F16 - 6
-
Team:Alert Production
Description
DM-5462 added linearization to IsrTask but had a few loose ends which this ticket aims to correct:
- I intended to enable linearization by default, but somehow lost that change.
- I intended to update obs_test to use null linearization, but I forgot and the previous item meant I didn't catch the omission
- It turns out that the butler data proxy object will not work with functors (attempting to call the retrieved item results in an error, rather than resolving the proxy). This is easily worked around by using immediate=True when retrieving linearizers. This didn't show up until
DM-6356because obs_decam is the only camera that uses linearization lookup tables, and obs_subaru avoids the problem by not returning a proxy.
Attachments
Issue Links
Activity
Looks fine to me
Hsin-Fang Chiang
added a comment - Looks fine to me ci_hsc showed another error that slipped through: I lost some changes to obs_subaru's ISR task (probably during a rebase). Again, by having linearization off by default I missed this error. I also managed to misspell the dataset name as "linearize" instead of "linearizer". ci_hsc now runs fine.
Hsin-Fang Chiang also approved the changes to obs_subaru. Jenkins runs, including ci_hsc. All seems well.
Hsin-Fang Chiang you already reviewed the changes to ip_isr (since they were originally committed as
DM-6356, and I simply renamed that branch to tickets/DM-6514with no code changes). However, I pushed the changes to obs_test too late for you to see them. Could you please review the changes to obs_test? The need for this was exposed by enabling linearization by default.