Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-6514

Minor fixes to linearization

    XMLWordPrintable

    Details

      Description

      DM-5462 added linearization to IsrTask but had a few loose ends which this ticket aims to correct:

      • I intended to enable linearization by default, but somehow lost that change.
      • I intended to update obs_test to use null linearization, but I forgot and the previous item meant I didn't catch the omission
      • It turns out that the butler data proxy object will not work with functors (attempting to call the retrieved item results in an error, rather than resolving the proxy). This is easily worked around by using immediate=True when retrieving linearizers. This didn't show up until DM-6356 because obs_decam is the only camera that uses linearization lookup tables, and obs_subaru avoids the problem by not returning a proxy.

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment -

            Hsin-Fang Chiang you already reviewed the changes to ip_isr (since they were originally committed as DM-6356, and I simply renamed that branch to tickets/DM-6514 with no code changes). However, I pushed the changes to obs_test too late for you to see them. Could you please review the changes to obs_test? The need for this was exposed by enabling linearization by default.

            Show
            rowen Russell Owen added a comment - Hsin-Fang Chiang you already reviewed the changes to ip_isr (since they were originally committed as DM-6356 , and I simply renamed that branch to tickets/ DM-6514 with no code changes). However, I pushed the changes to obs_test too late for you to see them. Could you please review the changes to obs_test? The need for this was exposed by enabling linearization by default.
            Hide
            hchiang2 Hsin-Fang Chiang added a comment -

            Looks fine to me

            Show
            hchiang2 Hsin-Fang Chiang added a comment - Looks fine to me
            Hide
            rowen Russell Owen added a comment - - edited

            ci_hsc showed another error that slipped through: I lost some changes to obs_subaru's ISR task (probably during a rebase). Again, by having linearization off by default I missed this error. I also managed to misspell the dataset name as "linearize" instead of "linearizer". ci_hsc now runs fine.

            Show
            rowen Russell Owen added a comment - - edited ci_hsc showed another error that slipped through: I lost some changes to obs_subaru's ISR task (probably during a rebase). Again, by having linearization off by default I missed this error. I also managed to misspell the dataset name as "linearize" instead of "linearizer". ci_hsc now runs fine.
            Hide
            rowen Russell Owen added a comment -

            Hsin-Fang Chiang also approved the changes to obs_subaru. Jenkins runs, including ci_hsc. All seems well.

            Show
            rowen Russell Owen added a comment - Hsin-Fang Chiang also approved the changes to obs_subaru. Jenkins runs, including ci_hsc. All seems well.

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Hsin-Fang Chiang
              Watchers:
              Hsin-Fang Chiang, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.