Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-6561

Fix order of flags in Kron photometry

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Story Points:
      0.5
    • Epic Link:
    • Sprint:
      DRP F16-1
    • Team:
      Data Release Production

      Description

      The flags are not added to the flag handler in the correct order for Kron photometry.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9249 Modify FlagHandler C++ and flagDecorator.py to make flag identification robust

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-6723 Add tests for order of flags to all measurment plugins

          • Won't Fix
          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Bob Armstrong – Proposed fix for this is on photometryKron PR#5.

            If you are happy with it, I would like to make the test case more generic and apply the same logic to everything in meas_base as well as other meas_extensions packages. I don't have time to do that on this ticket, but, if you agree, I'll file a follow-up ticket to do that some rainy afternoon.

            Show
            swinbank John Swinbank added a comment - Bob Armstrong – Proposed fix for this is on photometryKron PR#5 . If you are happy with it, I would like to make the test case more generic and apply the same logic to everything in meas_base as well as other meas_extensions packages. I don't have time to do that on this ticket, but, if you agree, I'll file a follow-up ticket to do that some rainy afternoon.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Jenkins running here: https://ci.lsst.codes/job/stack-os-matrix/12340/

            Show
            swinbank John Swinbank added a comment - Jenkins running here: https://ci.lsst.codes/job/stack-os-matrix/12340/
            Hide
            Permalink
            swinbank John Swinbank added a comment - - edited

            Hey Bob Armstrong any thoughts on this? – it'd be nice to merge before the end of the month if possible.

            Show
            swinbank John Swinbank added a comment - - edited Hey Bob Armstrong any thoughts on this? – it'd be nice to merge before the end of the month if possible.
            Hide
            Permalink
            rearmstr Bob Armstrong added a comment -

            Yes, sorry, I looked through the code last week and it all looked fine. I didn't have any comments. I think your proposed solution to test the flags are in the correct order was a good one and should be extended to other plugins.

            Show
            rearmstr Bob Armstrong added a comment - Yes, sorry, I looked through the code last week and it all looked fine. I didn't have any comments. I think your proposed solution to test the flags are in the correct order was a good one and should be extended to other plugins.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Thanks Bob. New ticket is DM-6723. This is merged to master.

            Show
            swinbank John Swinbank added a comment - Thanks Bob. New ticket is DM-6723 . This is merged to master.

              People

              Assignee:
              swinbank John Swinbank
              Reporter:
              rearmstr Bob Armstrong
              Reviewers:
              Bob Armstrong
              Watchers:
              Bob Armstrong, John Swinbank
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.