Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-6571

Remove the 'makeSourceCatalog' alias for the run method of SourceDetectionTask

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_algorithms
    • Labels:

      Description

      Line 288 in detection.py defines the alias makeSourceCatalog for the run method of the SourceDetectionTask and notes that the alias is deprecated and should be removed after checking for current usage.
      Remove the alias definition after checking to ensure that the alias is not used anywhere in the stack.

      Example of current usage in the stack (NB not complete!):

      1. pipe_tasks - multiBand.py: The runDetection method of DetectCoaddSources.py (line 280).

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-22815 Do release 21.0.0 of science pipelines

          • Done
          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-23085 Deprecate SourceDetectionTask.makeSourceCatalog

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-23277 Update ImageDifferenceTask to remove v20 deprecation warnings

          • Done
          mentioned in

          Page Loading...

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Vishal Kasliwal [X] – is the single example of usage you give in the issue description a complete list of all current usage?

            Show
            swinbank John Swinbank added a comment - Vishal Kasliwal [X] – is the single example of usage you give in the issue description a complete list of all current usage?
            Hide
            Permalink
            vpk24 Vishal Kasliwal [X] (Inactive) added a comment -

            I did not do a search - I was just cataloging an instance of the usage with the goal of demonstrating that it was not an un-used alias.

            Show
            vpk24 Vishal Kasliwal [X] (Inactive) added a comment - I did not do a search - I was just cataloging an instance of the usage with the goal of demonstrating that it was not an un-used alias.
            Hide
            Permalink
            lskelvin Lee Kelvin added a comment - - edited

            Remaining vestigial code in detection.py has been removed; good to merge to master following a successful Jenkins run. No other instances of makeSourceCatalog seem apparent anywhere else in the stack, including in the example above (which no longer exists on the master branch following DM-23085).

            Show
            lskelvin Lee Kelvin added a comment - - edited Remaining vestigial code in detection.py has been removed; good to merge to master following a successful Jenkins run . No other instances of makeSourceCatalog seem apparent anywhere else in the stack, including in the example above (which no longer exists on the master branch following DM-23085 ).
            Hide
            Permalink
            lskelvin Lee Kelvin added a comment -

            Thanks for the review of this Arun. Jenkins completed successfully (link above), so hopefully no remaining issues in removing this.

            Show
            lskelvin Lee Kelvin added a comment - Thanks for the review of this Arun. Jenkins completed successfully (link above), so hopefully no remaining issues in removing this.
            Hide
            Permalink
            kannawad Arun Kannawadi added a comment -

            Looks good to me.

            Show
            kannawad Arun Kannawadi added a comment - Looks good to me.
            Hide
            Permalink
            lskelvin Lee Kelvin added a comment -

            Thanks Arun. Branch merged to master and deleted, cheers.

            Show
            lskelvin Lee Kelvin added a comment - Thanks Arun. Branch merged to master and deleted, cheers.

              People

              Assignee:
              lskelvin Lee Kelvin
              Reporter:
              vpk24 Vishal Kasliwal [X] (Inactive)
              Reviewers:
              Arun Kannawadi
              Watchers:
              Arun Kannawadi, John Swinbank, Lee Kelvin
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.