Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: afw, datarel, ip_diffim, meas_astrom, meas_base, obs_cfht, obs_lsstSim, obs_sdss, psfex, skymap
-
Labels:
-
Story Points:0.25
-
Epic Link:
-
Sprint:AP S18-6
Description
The FITS keyword RADESYS is often misspelled as RADECSYS. Both appear to be accepted by our FITS reading code, but the latter is incorrect and we should not be using it. I found 31 instances across 27 files. I will attach the search results.
Attachments
Issue Links
- mentioned in
-
Page Loading...
Activity
| Field | Original Value | New Value |
|---|---|---|
| Attachment | RADECSYS instances.txt [ 28345 ] |
| Labels | SciencePipelines |
| Remote Link | This issue links to "Page (Confluence)" [ 17045 ] |
| Assignee | Kian-Tat Lim [ ktl ] | Russell Owen [ rowen ] |
| Risk Score | 0 |
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
| Epic Link |
|
| Sprint | AP S18-6 [ 686 ] | |
| Story Points | 0.25 |
| Reviewers | Meredith Rawls [ mrawls ] | |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
A bit of a fascinating rabbit hole to see how these FITS keywords have propagated... At any rate, these changes look fine, especially since you say all the unit tests still pass. Thanks for working on technical debt!
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
A few trivial changes to a few packages. This only affects unit tests and they still pass.