Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-6594

ObjectSizeStarSelector can produce numpy warnings

    Details

      Description

      ObjectSizeStarSelector can produce the following numpy warnings:

      objectSizeStarSelector.py:382: RuntimeWarning: invalid value encountered in less
        bad = numpy.logical_or(bad, width < self.config.widthMin)
      

      objectSizeStarSelector.py:383: RuntimeWarning: invalid value encountered in greater
        bad = numpy.logical_or(bad, width > self.config.widthMax)
      

      I suggest that the star selector handle this situation more gracefully, e.g. by reporting an appropriate exception or handling the data in an appropriate way. If logging a message would be helpful, then please do that. (DM-5428 handled a similar warning).

      One way to reproduce this is to build ci_hsc.

        Attachments

          Issue Links

            Activity

            vpk24 Vishal Kasliwal [X] (Inactive) created issue -
            swinbank John Swinbank made changes -
            Field Original Value New Value
            Description `ObjectSizeStarSelector` can produce the following numpy warnings:

            objectSizeStarSelector.py:382: RuntimeWarning: invalid value encountered in less
              bad = numpy.logical_or(bad, width < self.config.widthMin)

            objectSizeStarSelector.py:383: RuntimeWarning: invalid value encountered in greater
              bad = numpy.logical_or(bad, width > self.config.widthMax)

            I suggest that the star selector handle this situation more gracefully, e.g. by reporting an appropriate exception or handling the data in an appropriate way. If logging a message would be helpful, then please do that. (DM-5428 handled a similar warning).

            One way to reproduce this is to build ci_hsc.
            {{ObjectSizeStarSelector}} can produce the following numpy warnings:

            {{objectSizeStarSelector.py:382: RuntimeWarning: invalid value encountered in less
              bad = numpy.logical_or(bad, width < self.config.widthMin)}}

            {{objectSizeStarSelector.py:383: RuntimeWarning: invalid value encountered in greater
              bad = numpy.logical_or(bad, width > self.config.widthMax)}}

            I suggest that the star selector handle this situation more gracefully, e.g. by reporting an appropriate exception or handling the data in an appropriate way. If logging a message would be helpful, then please do that. (DM-5428 handled a similar warning).

            One way to reproduce this is to build ci_hsc.
            swinbank John Swinbank made changes -
            Description {{ObjectSizeStarSelector}} can produce the following numpy warnings:

            {{objectSizeStarSelector.py:382: RuntimeWarning: invalid value encountered in less
              bad = numpy.logical_or(bad, width < self.config.widthMin)}}

            {{objectSizeStarSelector.py:383: RuntimeWarning: invalid value encountered in greater
              bad = numpy.logical_or(bad, width > self.config.widthMax)}}

            I suggest that the star selector handle this situation more gracefully, e.g. by reporting an appropriate exception or handling the data in an appropriate way. If logging a message would be helpful, then please do that. (DM-5428 handled a similar warning).

            One way to reproduce this is to build ci_hsc.
            {{ObjectSizeStarSelector}} can produce the following numpy warnings:

            {code}
            objectSizeStarSelector.py:382: RuntimeWarning: invalid value encountered in less
              bad = numpy.logical_or(bad, width < self.config.widthMin)
            {code}

            {code}
            objectSizeStarSelector.py:383: RuntimeWarning: invalid value encountered in greater
              bad = numpy.logical_or(bad, width > self.config.widthMax)
            {code}

            I suggest that the star selector handle this situation more gracefully, e.g. by reporting an appropriate exception or handling the data in an appropriate way. If logging a message would be helpful, then please do that. (DM-5428 handled a similar warning).

            One way to reproduce this is to build ci_hsc.
            swinbank John Swinbank made changes -
            Issue Type Story [ 10001 ] Improvement [ 4 ]
            Labels SciencePipelines
            gcomoretto Gabriele Comoretto made changes -
            Remote Link This issue links to "Page (Confluence)" [ 22783 ]
            Hide
            swinbank John Swinbank added a comment -

            Addressed in DM-11776.

            Show
            swinbank John Swinbank added a comment - Addressed in DM-11776 .
            swinbank John Swinbank made changes -
            Link This issue duplicates DM-11776 [ DM-11776 ]
            swinbank John Swinbank made changes -
            Watchers Vishal Kasliwal [X] [ Vishal Kasliwal [X] ] [ None ]
            swinbank John Swinbank made changes -
            Resolution Done [ 10000 ]
            Status To Do [ 10001 ] Invalid [ 11005 ]

              People

              • Assignee:
                Unassigned
                Reporter:
                vpk24 Vishal Kasliwal [X] (Inactive)
                Watchers:
                John Swinbank
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel