Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-6631

Single-frame processing tasks are no longer usable without a Butler

    Details

    • Type: Bug
    • Status: Done
    • Priority: Major
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_tasks
    • Labels:
      None
    • Templates:
    • Story Points:
      3
    • Epic Link:
    • Sprint:
      DRP F16-1, DRP F16-2
    • Team:
      Data Release Production

      Description

      Adding a butler argument to the constructor signatures for CharacterizeImageTask, CalibrateTask, and ProcessCcdTask makes these tasks difficult to use without a butler.

      The fix is to make the butler argument optional (with a default of None), while adding another argument that allows a fully-constructed reference object loader to be provided directly instead.

      This is closely related to DM-6597, which has the opposite problem: pipe_drivers' SingleFrameDriverTask doesn't take a butler argument, but it needs to in order to provide one to ProcessCcdTask.

      I have a fix for this just about ready, but I'd like to add some unit tests that verify we can run all of these tasks both from the command-line and directly before calling it complete.

        Issue Links

          Activity

          Hide
          hchiang2 Hsin-Fang Chiang added a comment -

          Agree, and thanks for pointing out meas_base. I think SuperTask work might want to know where all CmdLineTasks are.

          Show
          hchiang2 Hsin-Fang Chiang added a comment - Agree, and thanks for pointing out meas_base. I think SuperTask work might want to know where all CmdLineTasks are.
          Hide
          price Paul Price added a comment -

          Please add new common mapper entries in daf_butlerUtils rather than in every obs package.

          Show
          price Paul Price added a comment - Please add new common mapper entries in daf_butlerUtils rather than in every obs package.
          Hide
          jbosch Jim Bosch added a comment -

          Paul Price That sounds great, but do you have some docs or an example of how to do that?

          Show
          jbosch Jim Bosch added a comment - Paul Price That sounds great, but do you have some docs or an example of how to do that?
          Hide
          jbosch Jim Bosch added a comment -

          Found the docs here: https://community.lsst.org/t/centrally-defined-butler-datasets/841 (I was confused by the fact that only datasets.yaml currently exists).

          I've moved the _config entries (except isr_config) to daf_butlerUtils. The metadata entries and isr_config have to stay because they differ between obs packages.

          Just waiting on final confirmation from Jenkins now.

          Show
          jbosch Jim Bosch added a comment - Found the docs here: https://community.lsst.org/t/centrally-defined-butler-datasets/841 (I was confused by the fact that only datasets.yaml currently exists). I've moved the _config entries (except isr_config) to daf_butlerUtils. The metadata entries and isr_config have to stay because they differ between obs packages. Just waiting on final confirmation from Jenkins now.
          Hide
          jbosch Jim Bosch added a comment -

          Merged to master.

          Show
          jbosch Jim Bosch added a comment - Merged to master.

            People

            • Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Hsin-Fang Chiang
              Watchers:
              Hsin-Fang Chiang, Jim Bosch, Paul Price, Robert Lupton, Russell Owen, Simon Krughoff
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development

                  Agile