Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: pipe_tasks
-
Labels:None
-
Story Points:3
-
Epic Link:
-
Sprint:DRP F16-1, DRP F16-2
-
Team:Data Release Production
Description
Adding a butler argument to the constructor signatures for CharacterizeImageTask, CalibrateTask, and ProcessCcdTask makes these tasks difficult to use without a butler.
The fix is to make the butler argument optional (with a default of None), while adding another argument that allows a fully-constructed reference object loader to be provided directly instead.
This is closely related to DM-6597, which has the opposite problem: pipe_drivers' SingleFrameDriverTask doesn't take a butler argument, but it needs to in order to provide one to ProcessCcdTask.
I have a fix for this just about ready, but I'd like to add some unit tests that verify we can run all of these tasks both from the command-line and directly before calling it complete.
Attachments
Issue Links
- is blocked by
-
DM-6641 Add exact variants of image comparison test utilities
- Done
Activity
Please add new common mapper entries in daf_butlerUtils rather than in every obs package.
Paul Price
added a comment - Please add new common mapper entries in daf_butlerUtils rather than in every obs package. Paul Price That sounds great, but do you have some docs or an example of how to do that?
Found the docs here: https://community.lsst.org/t/centrally-defined-butler-datasets/841 (I was confused by the fact that only datasets.yaml currently exists).
I've moved the _config entries (except isr_config) to daf_butlerUtils. The metadata entries and isr_config have to stay because they differ between obs packages.
Just waiting on final confirmation from Jenkins now.
Agree, and thanks for pointing out meas_base. I think SuperTask work might want to know where all CmdLineTasks are.