Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: pipe_tasks
-
Labels:None
-
Story Points:3
-
Epic Link:
-
Sprint:DRP F16-1, DRP F16-2
-
Team:Data Release Production
Description
Adding a butler argument to the constructor signatures for CharacterizeImageTask, CalibrateTask, and ProcessCcdTask makes these tasks difficult to use without a butler.
The fix is to make the butler argument optional (with a default of None), while adding another argument that allows a fully-constructed reference object loader to be provided directly instead.
This is closely related to DM-6597, which has the opposite problem: pipe_drivers' SingleFrameDriverTask doesn't take a butler argument, but it needs to in order to provide one to ProcessCcdTask.
I have a fix for this just about ready, but I'd like to add some unit tests that verify we can run all of these tasks both from the command-line and directly before calling it complete.
Attachments
Issue Links
- is blocked by
-
DM-6641 Add exact variants of image comparison test utilities
- Done
Activity
| Field | Original Value | New Value |
|---|---|---|
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
| Story Points | 1 | 3 |
| Description |
Adding a butler argument to the constructor signatures for {{CharacterizeImageTask}}, {{CalibrateTask}}, and {{ProcessCcdTask} makes these tasks difficult to use without a butler.
The fix is to make the butler argument optional (with a default of None), while adding another argument that allows a fully-constructed reference object loader to be provided directly instead. This is closely related to I have a fix for this just about ready, so this will be out for review shortly. |
Adding a butler argument to the constructor signatures for {{CharacterizeImageTask}}, {{CalibrateTask}}, and {{ProcessCcdTask} makes these tasks difficult to use without a butler.
The fix is to make the butler argument optional (with a default of None), while adding another argument that allows a fully-constructed reference object loader to be provided directly instead. This is closely related to I have a fix for this just about ready, but I'd like to add some unit tests that verify we can run all of these tasks both from the command-line and directly before calling it complete. |
| Description |
Adding a butler argument to the constructor signatures for {{CharacterizeImageTask}}, {{CalibrateTask}}, and {{ProcessCcdTask} makes these tasks difficult to use without a butler.
The fix is to make the butler argument optional (with a default of None), while adding another argument that allows a fully-constructed reference object loader to be provided directly instead. This is closely related to I have a fix for this just about ready, but I'd like to add some unit tests that verify we can run all of these tasks both from the command-line and directly before calling it complete. |
Adding a butler argument to the constructor signatures for {{CharacterizeImageTask}}, {{CalibrateTask}}, and {{ProcessCcdTask]} makes these tasks difficult to use without a butler.
The fix is to make the butler argument optional (with a default of None), while adding another argument that allows a fully-constructed reference object loader to be provided directly instead. This is closely related to I have a fix for this just about ready, but I'd like to add some unit tests that verify we can run all of these tasks both from the command-line and directly before calling it complete. |
| Description |
Adding a butler argument to the constructor signatures for {{CharacterizeImageTask}}, {{CalibrateTask}}, and {{ProcessCcdTask]} makes these tasks difficult to use without a butler.
The fix is to make the butler argument optional (with a default of None), while adding another argument that allows a fully-constructed reference object loader to be provided directly instead. This is closely related to I have a fix for this just about ready, but I'd like to add some unit tests that verify we can run all of these tasks both from the command-line and directly before calling it complete. |
Adding a butler argument to the constructor signatures for {{CharacterizeImageTask}}, {{CalibrateTask}}, and {{ProcessCcdTask}} makes these tasks difficult to use without a butler.
The fix is to make the butler argument optional (with a default of None), while adding another argument that allows a fully-constructed reference object loader to be provided directly instead. This is closely related to I have a fix for this just about ready, but I'd like to add some unit tests that verify we can run all of these tasks both from the command-line and directly before calling it complete. |
| Epic Link |
|
| Sprint | DRP F16-1 [ 225 ] |
| Reviewers | Robert Lupton, Russell Owen, Simon Krughoff [ rhl, rowen, krughoff ] | |
| Watchers | Hsin-Fang Chiang, Jim Bosch [ Hsin-Fang Chiang, Jim Bosch ] | Hsin-Fang Chiang, Jim Bosch, Robert Lupton, Russell Owen, Simon Krughoff [ Hsin-Fang Chiang, Jim Bosch, Robert Lupton, Russell Owen, Simon Krughoff ] |
| Reviewers | Hsin-Fang Chiang [ hchiang2 ] | |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
Hsin-Fang Chiang
made changes -
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
| Sprint | DRP F16-1 [ 225 ] | TCAMS 2016_03, DRP F16-1 [ 209, 225 ] |
| Rank | Ranked higher |
| Sprint | TCAMS 2016_03, DRP F16-1 [ 209, 225 ] | DRP F16-1, DRP F16-2 [ 225, 231 ] |
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
Hsin-Fang Chiang
made changes -