Details

    • Type: Bug
    • Status: Done
    • Priority: Major
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_tasks
    • Labels:
      None
    • Templates:
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      DRP F16-3
    • Team:
      Data Release Production

      Description

      Paul Price points out a typo in CoaddSrcTransformTask: self should not be repeated.

        Issue Links

          Activity

          Hide
          swinbank John Swinbank added a comment -

          Hey Fred Moolekamp — do you have time to take a quick look at this?

          The basic fix is trivial, but I did some cleaning up and added tests while I was at it.

          It might not be immediately obvious what all of this code is used for: if you'd like me to talk it through with you, give me a shout.

          PRs in obs_test and pipe_tasks; Jenkins #14169.

          Show
          swinbank John Swinbank added a comment - Hey Fred Moolekamp — do you have time to take a quick look at this? The basic fix is trivial, but I did some cleaning up and added tests while I was at it. It might not be immediately obvious what all of this code is used for: if you'd like me to talk it through with you, give me a shout. PRs in obs_test and pipe_tasks ; Jenkins #14169 .
          Hide
          fred3m Fred Moolekamp added a comment -

          So I finally understand enough to review this ticket. I had a comment about the conversion of the test module to pytest although it looks like Paul Price updated testCoadds.py in DM-7235. So this will have to be rebased but after that (and a typo in one of the comments) this should be ready to merge.

          Show
          fred3m Fred Moolekamp added a comment - So I finally understand enough to review this ticket. I had a comment about the conversion of the test module to pytest although it looks like Paul Price updated testCoadds.py in DM-7235 . So this will have to be rebased but after that (and a typo in one of the comments) this should be ready to merge.
          Hide
          swinbank John Swinbank added a comment -

          Typo fixed; rebased; merged. Thanks!

          Show
          swinbank John Swinbank added a comment - Typo fixed; rebased; merged. Thanks!

            People

            • Assignee:
              swinbank John Swinbank
              Reporter:
              swinbank John Swinbank
              Reviewers:
              Fred Moolekamp
              Watchers:
              Fred Moolekamp, John Swinbank
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development

                  Agile