Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-6661

ConfigDictField says "Inequality in keys for..." even if I give 2 same configurations

    Details

    • Type: Bug
    • Status: Done
    • Priority: Major
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pex_config
    • Labels:
      None
    • Templates:
    • Story Points:
      0.5
    • Epic Link:
    • Sprint:
      DRP F16-1
    • Team:
      Data Release Production

      Description

      From HSC-1401:

      config.py:

      from lsst.meas.photocal.colorterms import ColortermGroupConfig
       
      for key in ['i', 'i2', 'y', 'r', 'N1', 'N2', 'N3', 'z']:
          root.calibrate.photocal.colorterms.library[key] = ColortermGroupConfig.fromValues({})

      This comamnd line

      rm -fr output ; for i in {1..2} ; do processCcd.py ./HSC --output output -C config.py  ; done
      

      raises following error

      2016-06-01T02:43:45: processCcd FATAL: Comparing configuration: Inequality in keys for calibrate.photocal.colorterms.library: ['z', 'i', 'i2', 'r', 'y', 'N1', 'N2', 'N3'] != ['N3', 'i', 'i2', 'r', 'y', 'N1', 'N2', 'z']
      2016-06-01T02:43:45: processCcd FATAL: Failed in task initialization: Config does match existing config on disk for this task; tasks configurations must be consistent within the same output repo (override with --clobber-config)
      

        Issue Links

          Activity

          Hide
          price Paul Price added a comment -

          Vishal Kasliwal [X], could you please look at this?

          price@price-laptop:~/LSST/pex/config (tickets/DM-6661=) $ git sub
          commit 817dd40d5e6e245276f3359a4c8505cfb05c1f86
          Author: michitaro.koike <michitaro.nike@gmail.com>
          Date:   Thu Jun 23 13:19:21 2016 +0900
           
              ConfigDictField: fix equality check
              
              ConfigDictField said "Inequality in keys for..." even if we give the
              same configurations, because the keys could be in a different order.
           
           python/lsst/pex/config/configDictField.py |  2 +-
           python/lsst/pex/config/dictField.py       |  2 +-
           tests/configDictField.py                  | 24 ++++++++++++++++++++++++
           tests/dictField.py                        | 20 ++++++++++++++++++++
           4 files changed, 46 insertions(+), 2 deletions(-)
          

          Show
          price Paul Price added a comment - Vishal Kasliwal [X] , could you please look at this? price@price-laptop:~/LSST/pex/config (tickets/DM-6661=) $ git sub commit 817dd40d5e6e245276f3359a4c8505cfb05c1f86 Author: michitaro.koike <michitaro.nike@gmail.com> Date: Thu Jun 23 13:19:21 2016 +0900   ConfigDictField: fix equality check ConfigDictField said "Inequality in keys for..." even if we give the same configurations, because the keys could be in a different order.   python/lsst/pex/config/configDictField.py | 2 +- python/lsst/pex/config/dictField.py | 2 +- tests/configDictField.py | 24 ++++++++++++++++++++++++ tests/dictField.py | 20 ++++++++++++++++++++ 4 files changed, 46 insertions(+), 2 deletions(-)
          Hide
          vpk24 Vishal Kasliwal [X] (Inactive) added a comment -

          Looks fine. Please feel free to merge to master...

          Show
          vpk24 Vishal Kasliwal [X] (Inactive) added a comment - Looks fine. Please feel free to merge to master...
          Hide
          price Paul Price added a comment -

          Thanks!

          Merged to master.

          Show
          price Paul Price added a comment - Thanks! Merged to master.

            People

            • Assignee:
              price Paul Price
              Reporter:
              price Paul Price
              Reviewers:
              Vishal Kasliwal [X] (Inactive)
              Watchers:
              Paul Price, Vishal Kasliwal [X] (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development

                  Agile