# meas_extensions_ngmix has no SConstruct

XMLWordPrintable

## Details

• Type: Bug
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
None
• Story Points:
0.25
• Sprint:
DRP F16-1
• Team:
Data Release Production

## Description

meas_extensions_ngmix has no SConstruct file.

That means that running scons tests does nothing useful.

Simply dropping in a basic SConstruct breaks:

 Setting up environment to build package 'meas_extensions_ngmix'. Failed to load required dependencies: "ngmix" 

## Activity

Hide
John Swinbank added a comment -

Perry Gee, Nate Lust – I'm adding you as watchers on this since I think you did the bulk of the work and the reviewing on meas_extensions_ngmix. Looks like nobody ever got as far as running "scons tests". Not a big problem – stuff like that happens – but it's a good opportunity to learn lessons about what we should be checking for in future.

Show
John Swinbank added a comment - Perry Gee , Nate Lust – I'm adding you as watchers on this since I think you did the bulk of the work and the reviewing on meas_extensions_ngmix. Looks like nobody ever got as far as running "scons tests". Not a big problem – stuff like that happens – but it's a good opportunity to learn lessons about what we should be checking for in future.
Hide
John Swinbank added a comment -

Jim Bosch, do you have time to give this a quick look? Changes are pretty trivial; my only hesitation is that I'm not completely sure if the cfg for ngmix is correct.

I note your comment on HipChat that we "de facto" don't use the .cfg for pure Python packages. I've added one here because I think we should clarify the docs before adopting that position (that's DM-6721), and because – at least until those docs are clear – having meas_extensions_ngmix able to declare a dependency on ngmix without breaking seems like the sane thing to do.

Show
John Swinbank added a comment - Jim Bosch , do you have time to give this a quick look? Changes are pretty trivial; my only hesitation is that I'm not completely sure if the cfg for ngmix is correct. I note your comment on HipChat that we "de facto" don't use the .cfg for pure Python packages. I've added one here because I think we should clarify the docs before adopting that position (that's DM-6721 ), and because – at least until those docs are clear – having meas_extensions_ngmix able to declare a dependency on ngmix without breaking seems like the sane thing to do.
Hide
Jim Bosch added a comment -

Looks fine. I'm ambivalent about whether we should add a .cfg to ngmix, but your position that that we should is a reasonable one.

Show
Jim Bosch added a comment - Looks fine. I'm ambivalent about whether we should add a .cfg to ngmix, but your position that that we should is a reasonable one.
Hide
John Swinbank added a comment -

Thanks Jim! Merged.

Show
John Swinbank added a comment - Thanks Jim! Merged.

## People

• Assignee:
John Swinbank
Reporter:
John Swinbank
Reviewers:
Jim Bosch
Watchers:
Jim Bosch, John Swinbank, Nate Lust, Perry Gee