Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: None
-
Labels:None
-
Story Points:0.25
-
Epic Link:
-
Sprint:DRP F16-1
-
Team:Data Release Production
Description
As of DM-6127, we've clarified the licensing position of ngmix. Please ensure that we're actually carrying a version of ngmix which has a license attached in our repository.
Attachments
Issue Links
Activity
I will look at it tomorrow. John Swinbank
Perry Gee
added a comment - I will look at it tomorrow. John Swinbank Thanks Perry!
As you already know, I don't really understand how the distribution mechanism works for these external packages. So I did prep,config,build by using eupspkg -er, then did the install step by hand.
Everything seems to work between ngmix and meas_extensions_ngmix with the new release. Not sure why Erin changes LM_DIV_ZERO to DIV_ZERO. He told me yesterday that they symbols were stable.
I also ran the tests I am adding for DM-6300, and they also seemed to run fine as well.
I don't really understand the changes to ngmix/ups, but the table and cfg files appear to be correct. The .sh file is a mystery.
Perry Gee
added a comment - As you already know, I don't really understand how the distribution mechanism works for these external packages. So I did prep,config,build by using eupspkg -er, then did the install step by hand.
Everything seems to work between ngmix and meas_extensions_ngmix with the new release. Not sure why Erin changes LM_DIV_ZERO to DIV_ZERO. He told me yesterday that they symbols were stable.
I also ran the tests I am adding for DM-6300 , and they also seemed to run fine as well.
I don't really understand the changes to ngmix/ups, but the table and cfg files appear to be correct. The .sh file is a mystery. I did not touch the pull request. As the changes were minimal, I examined them with git diff.
I don't see any issues.
Perry Gee
added a comment - I did not touch the pull request. As the changes were minimal, I examined them with git diff.
I don't see any issues. Thanks Perry!
Perry Gee, could you please review this?
There are (quite small) changes on both ngmix and meas_extensions_ngmix.
I would like to merge this work in time for the end of the cycle, ie no later than Thursday. If you will be unable to perform the review by then, please let me know so I can find somebody else. Thank you!