Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-679

Megacam CCD defects are not handled properly in obs_cfht

    XMLWordPrintable

Details

    Description

      Megacam CCD defects files should be selected according to a keyword present in the image fits header (currently they are selected according to a date).
      Independently of the selection mechanism, there are also some questions on the validity of the current defects files. Defects footprints can be generated from the original Elixir defects files.
      According to Pierre Astier, for filters i and z, the defects footprints should be enlarged by 1 pixel in the y direction .

      Attachments

        Activity

          My only further comment is that there is an extra assert in megacamMapper.py at line 112. On line 114 the length of the return is checked and a much more informative exception is raised. My opinion is that the assert should be removed.

          Other than that, feel free to merge

          krughoff Simon Krughoff (Inactive) added a comment - My only further comment is that there is an extra assert in megacamMapper.py at line 112. On line 114 the length of the return is checked and a much more informative exception is raised. My opinion is that the assert should be removed. Other than that, feel free to merge
          krughoff Simon Krughoff (Inactive) added a comment - - edited

          This looks fine for the most part. I'm leaving this in review until you can address my first question.

          A couple of comments:
          I don't see the change to the radial distortion. Did that get pushed? I'd like to see that before this is merged.
          There are extra blank lines introduced at lines 76 and 77 of python/lsst/obs/cfht/ingest.py that should be removed.

          krughoff Simon Krughoff (Inactive) added a comment - - edited This looks fine for the most part. I'm leaving this in review until you can address my first question. A couple of comments: I don't see the change to the radial distortion. Did that get pushed? I'd like to see that before this is merged. There are extra blank lines introduced at lines 76 and 77 of python/lsst/obs/cfht/ingest.py that should be removed.

          People

            boutigny Dominique Boutigny
            boutigny Dominique Boutigny
            Simon Krughoff (Inactive)
            Dominique Boutigny, Simon Krughoff (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - Not Specified
                Not Specified
                Logged:
                Time Spent - 1 week
                1w

                Jenkins

                  No builds found.