Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-6925

star selector and PSF determiner are selecting stars that are not valid point sources

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_algorithms
    • Labels:
      None
    • Story Points:
      6
    • Epic Link:
    • Sprint:
      DRP F16-3, DRP F16-4, DRP F16-5
    • Team:
      Data Release Production

      Description

      When turning on CModel a more robust extendedness classifier relieved that many of the stars being used as PSF candidates were being classified as extended as shown in the attached plot. This plot was generated from the output of ci_hsc. Work should be done to determine why these stars are mistakenly being selected and fix the bad behavior. Additionally the temporary work around in ci_hsc, where the success criteria for validate sources in validate.py should be reverted from 85% to 95%.

        Attachments

          Issue Links

            Activity

            Hide
            nlust Nate Lust added a comment -

            Sorry for the delay in reviewing this, the reversion looks good to me. If ci_hsc runs without a problem you are good to merge and close this ticket.

            Show
            nlust Nate Lust added a comment - Sorry for the delay in reviewing this, the reversion looks good to me. If ci_hsc runs without a problem you are good to merge and close this ticket.
            Hide
            pgee Perry Gee added a comment -

            I just moved the validate criterion from 85% to 95% and reran ci_hsc. I think this is the reversal John was asking for. Then I tried to run ci_hsc to see if it still would run sucessfully.

            I again had troubles running it on my personal machine, so I ran it on Jenkins. Turned out that to get this to run, a change had to be made in obs_subaru. This is already checked in to master to fix a build break.

            The change in ci_hsc to move the threshold back to 95% seems to run OK with that change to obs_subaru.
            .

            Show
            pgee Perry Gee added a comment - I just moved the validate criterion from 85% to 95% and reran ci_hsc. I think this is the reversal John was asking for. Then I tried to run ci_hsc to see if it still would run sucessfully. I again had troubles running it on my personal machine, so I ran it on Jenkins. Turned out that to get this to run, a change had to be made in obs_subaru. This is already checked in to master to fix a build break. The change in ci_hsc to move the threshold back to 95% seems to run OK with that change to obs_subaru. .
            Hide
            swinbank John Swinbank added a comment -

            Actually, regardless of the above: even if it's impossible for anybody to reproduce the original problem, this issue still isn't complete since the threshold in ci_hsc has not been reset per the original description. Please do so.

            Show
            swinbank John Swinbank added a comment - Actually, regardless of the above: even if it's impossible for anybody to reproduce the original problem, this issue still isn't complete since the threshold in ci_hsc has not been reset per the original description. Please do so.
            Hide
            swinbank John Swinbank added a comment -

            Hey Perry Gee, Nate Lust, I just want to be sure — is it true that Nate can't repeat his earlier results with the current version of the stack, or rather that Perry hasn't been able to?

            Show
            swinbank John Swinbank added a comment - Hey Perry Gee , Nate Lust , I just want to be sure — is it true that Nate can't repeat his earlier results with the current version of the stack, or rather that Perry hasn't been able to?
            Hide
            pgee Perry Gee added a comment -

            Could not reproduce this problem with the current stack and version of ci_hsc.

            There are some problem cases, many of them at the edges of the coadd. It may be that there are fewer samples covering these areas, and therefore lower SNR. But neither of the coadds in this practice set exceeded 5% failure rate as was reported in this issue.

            Show
            pgee Perry Gee added a comment - Could not reproduce this problem with the current stack and version of ci_hsc. There are some problem cases, many of them at the edges of the coadd. It may be that there are fewer samples covering these areas, and therefore lower SNR. But neither of the coadds in this practice set exceeded 5% failure rate as was reported in this issue.

              People

              • Assignee:
                pgee Perry Gee
                Reporter:
                nlust Nate Lust
                Reviewers:
                Nate Lust
                Watchers:
                John Swinbank, Nate Lust, Paul Price, Perry Gee
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel