Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-6928

HSC backport: Include PSF moments in the output tables

    Details

    • Type: Story
    • Status: Done
    • Priority: Major
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Templates:
    • Story Points:
      4
    • Sprint:
      DRP F16-2
    • Team:
      Data Release Production

      Description

      This is effectively a port of HSC-110 though, due to the considerable differences in bookkeeping for the SdssShape code, this will be more of a reimplementation.

        Activity

        Hide
        swinbank John Swinbank added a comment -

        Lauren asked me to tweak the code slightly before this is ready to merge. Pulling it out of review while I do so. Watch this space...

        Show
        swinbank John Swinbank added a comment - Lauren asked me to tweak the code slightly before this is ready to merge. Pulling it out of review while I do so. Watch this space...
        Hide
        swinbank John Swinbank added a comment -

        Now ready for review on meas_base PR#45.

        Show
        swinbank John Swinbank added a comment - Now ready for review on meas_base PR#45 .
        Hide
        jbosch Jim Bosch added a comment -

        Looks good. I only have a few minor comments on the PR. Given yours (and Pim Schellart's?) concerns about messiness with flag handlers, the workarounds in that area were not nearly as bad as I expected.

        Show
        jbosch Jim Bosch added a comment - Looks good. I only have a few minor comments on the PR. Given yours (and Pim Schellart 's?) concerns about messiness with flag handlers, the workarounds in that area were not nearly as bad as I expected.
        Hide
        swinbank John Swinbank added a comment -

        Thanks! I've updated according to your review comments, including switching the test case to the new boilerplate (which actually involved a fair bit of fiddling, thanks to DM-6998 & issues with test discovery), and am using Quadrupole instead of ShapeResult. Currently in Jenkins, and, assuming that passes, I'll merge later today.

        Show
        swinbank John Swinbank added a comment - Thanks! I've updated according to your review comments, including switching the test case to the new boilerplate (which actually involved a fair bit of fiddling, thanks to DM-6998 & issues with test discovery), and am using Quadrupole instead of ShapeResult . Currently in Jenkins, and, assuming that passes, I'll merge later today.
        Hide
        swinbank John Swinbank added a comment -

        Merged.

        Show
        swinbank John Swinbank added a comment - Merged.

          People

          • Assignee:
            lauren Lauren MacArthur
            Reporter:
            lauren Lauren MacArthur
            Reviewers:
            Jim Bosch
            Watchers:
            Jim Bosch, John Swinbank, Lauren MacArthur
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Agile