Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-6986

Suggest Tasks' logging migration in meas packages

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      With the transition of Tasks' logs from lsst.pex.logging to lsst.log (DM-6999), suggest changesets using lsst::log instead of pex::logging in meas packages that has dependency on Tasks' logging framework.

        Attachments

          Issue Links

            Activity

            Hide
            sullivan Ian Sullivan added a comment -

            I just noticed this is still marked "in review". Do you still need something from me?

            Show
            sullivan Ian Sullivan added a comment - I just noticed this is still marked "in review". Do you still need something from me?
            Hide
            hchiang2 Hsin-Fang Chiang added a comment -

            Ian Sullivan sorry for my long silence and thanks for checking. I added one more commit to meas_astrom, would you mind taking a look of this: https://github.com/lsst/meas_astrom/pull/38/commits/bf568b1853fdd4f49e4fbae7f2fc731a15dc76aa

            I haven't addressed all of your concerns yet, but will sure do so before merging. Merging of this ticket will be coordinated with DM-6999 and DM-6984.

            Vishal Kasliwal [X] may you please put this to "reviewed" after you review it and are happy with the changes of meas_algorithms, meas_deblender, and meas_modelfit?

            Show
            hchiang2 Hsin-Fang Chiang added a comment - Ian Sullivan sorry for my long silence and thanks for checking. I added one more commit to meas_astrom , would you mind taking a look of this: https://github.com/lsst/meas_astrom/pull/38/commits/bf568b1853fdd4f49e4fbae7f2fc731a15dc76aa I haven't addressed all of your concerns yet, but will sure do so before merging. Merging of this ticket will be coordinated with DM-6999 and DM-6984 . Vishal Kasliwal [X] may you please put this to "reviewed" after you review it and are happy with the changes of meas_algorithms, meas_deblender, and meas_modelfit?
            Hide
            sullivan Ian Sullivan added a comment -
            Show
            sullivan Ian Sullivan added a comment - Those additional changes in https://github.com/lsst/meas_astrom/pull/38/commits/bf568b1853fdd4f49e4fbae7f2fc731a15dc76aa look fine to me.
            Hide
            vpk24 Vishal Kasliwal [X] (Inactive) added a comment -

            Looks good - feel free to merge to master.

            Show
            vpk24 Vishal Kasliwal [X] (Inactive) added a comment - Looks good - feel free to merge to master.
            Hide
            hchiang2 Hsin-Fang Chiang added a comment -

            Merged to master with DM-6999

            Show
            hchiang2 Hsin-Fang Chiang added a comment - Merged to master with DM-6999

              People

              • Assignee:
                hchiang2 Hsin-Fang Chiang
                Reporter:
                hchiang2 Hsin-Fang Chiang
                Reviewers:
                Ian Sullivan, Vishal Kasliwal [X] (Inactive)
                Watchers:
                Hsin-Fang Chiang, Ian Sullivan, Vishal Kasliwal [X] (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel