Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-6995

cosmetic fixes for LDM-151

    Details

    • Team:
      DM Science

      Description

      I scanned parts of ldm-151 (draft branch) and ended up making few minor fixes, see branch u/jbecla/201607-fixes, feel free to accept them or ignore . Also, I noticed few other things that I haven't fixed:

      • consider refreshing author list, eg I know Frossie spent time contributing
      • SUI --> SUIT?
      • break figure 1 into two and turn 90 degrees?
      • figure 2 turn 90 degrees?
      • "The data products produced by Alert production are given in table ." - missing table number. This is on page 21
      • "this would likely only be able to sample the selection function over a subset" this sentence seems unfinished
      • "A catalog of Sources with measured features (as described in ??)." Maybe you want to refer to LDM-153 (db schema)?
      • OCS introduced on page 17, no need to reintroduce on page 23?
      • page 24: "Source detection to the 5σ limit of" something is broken here

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            Actually, I see that John Swinbank merged Jacek Becla's fix up branch back in August... (grumble, branches not being deleted after merging and tickets not being annotated to reflect this, grumble).

            Figurs 1 and 2 are the remaining items from this ticket.

            Show
            tjenness Tim Jenness added a comment - Actually, I see that John Swinbank merged Jacek Becla 's fix up branch back in August... (grumble, branches not being deleted after merging and tickets not being annotated to reflect this, grumble). Figurs 1 and 2 are the remaining items from this ticket.
            Hide
            tjenness Tim Jenness added a comment -

            Regarding figures 1 and 2, if I just rotate them then everything looks fine to me and they are still readable. I assume that the reason we are not wanting to split up Fig 1 is because it is deliberately identical to the version used in the other document.

            Show
            tjenness Tim Jenness added a comment - Regarding figures 1 and 2, if I just rotate them then everything looks fine to me and they are still readable. I assume that the reason we are not wanting to split up Fig 1 is because it is deliberately identical to the version used in the other document.
            Hide
            mjuric Mario Juric added a comment -

            I removed the figure-formerly-known-as-Figure-1 (the one mentioning "Applications"), and reworded the text not to use the term (I'm not sure whether the refreshed LDM-148 will continue to use the same definitions/layering). I notice that Figure 2 has been rotated (I'm assuming by Tim Jenness; thanks!). Closing.

            Show
            mjuric Mario Juric added a comment - I removed the figure-formerly-known-as-Figure-1 (the one mentioning "Applications"), and reworded the text not to use the term (I'm not sure whether the refreshed LDM-148 will continue to use the same definitions/layering). I notice that Figure 2 has been rotated (I'm assuming by Tim Jenness ; thanks!). Closing.
            Hide
            tjenness Tim Jenness added a comment -

            Figure 2 is still incorrectly rotated if I look at the figure. I don't really understand why it's not done as a normal table. Does that figure come from some other document or a shared image repository?

            Show
            tjenness Tim Jenness added a comment - Figure 2 is still incorrectly rotated if I look at the figure. I don't really understand why it's not done as a normal table. Does that figure come from some other document or a shared image repository?
            Hide
            tjenness Tim Jenness added a comment -

            I've created a new pull request that replaces figure 1 with a table.

            Show
            tjenness Tim Jenness added a comment - I've created a new pull request that replaces figure 1 with a table.

              People

              • Assignee:
                mjuric Mario Juric
                Reporter:
                jbecla Jacek Becla
                Watchers:
                Eric Bellm, Jacek Becla, Jim Bosch, John Swinbank, Mario Juric, Simon Krughoff, Tim Jenness, Zeljko Ivezic
              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel