Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-6999

Use lsst::log in pipe_base and pipe_tasks

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_base, pipe_tasks
    • Labels:
      None

      Description

      Per RFC-203, switch Task's logs from using pex.logging to lsst.log in pipe_base and pipe_tasks (stage 2)
      This implements the main idea of RFC-203 and migrate the logging framework used in the task framework.

        Attachments

          Issue Links

          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-203 Use lsst::log in pipeline tasks

          • Implemented
          is triggering

          Bug - A problem which impairs or prevents the functions of the product. DM-7533 astrometry_net log is not controllable from the command line interface

          • Done

          Bug - A problem which impairs or prevents the functions of the product. DM-7741 Missed incompatible logging changes in Python + migrate meas_astrom

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7548 constructBias.py crashes with errors about log

          • Done
          relates to

          Bug - A problem which impairs or prevents the functions of the product. DM-7725 Fix missing lsst.log update and build dependencies

          • Done

          Bug - A problem which impairs or prevents the functions of the product. DM-7740 Fix missing lsst.log update

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-3532 Test new lsst::log logging framework

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-6986 Suggest Tasks' logging migration in meas packages

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7150 Configure a default log for tests

          • Done
          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            17 older comments
            Hide
            Permalink
            rowen Russell Owen added a comment -

            For the record, here is the table of old levels vs new levels:

                      pex_logging       log
            		 
            TRACE     -trace level     5000
            		 
            DEBUG     -10             10000
            		 
            INFO        0             20000
            		 
            WARN[ING]  10             30000
            		 
            ERROR     N/A             40000
            		 
            FATAL      20             50000

            Show
            rowen Russell Owen added a comment - For the record, here is the table of old levels vs new levels: pex_logging log TRACE -trace level 5000 DEBUG -10 10000 INFO 0 20000 WARN[ING] 10 30000 ERROR N/A 40000 FATAL 20 50000
            Hide
            Permalink
            hchiang2 Hsin-Fang Chiang added a comment -

            Many thanks to the reviewers Russell Owen, Ian Sullivan, and Vishal Kasliwal [X] for reviewing the 11 packages! I think I have addressed all concerns brought up during the review. I'm going though the changes a few more times, running CI, and will run some command line tasks locally as extra manual tests. After that I'll merge the changes. Afterwards I will post on c.l.o. to announce the changes.

            Show
            hchiang2 Hsin-Fang Chiang added a comment - Many thanks to the reviewers Russell Owen , Ian Sullivan , and Vishal Kasliwal [X] for reviewing the 11 packages! I think I have addressed all concerns brought up during the review. I'm going though the changes a few more times, running CI, and will run some command line tasks locally as extra manual tests. After that I'll merge the changes. Afterwards I will post on c.l.o. to announce the changes.
            Hide
            Permalink
            hchiang2 Hsin-Fang Chiang added a comment -

            Passed Jenkins, with lsst_ci:
            https://ci.lsst.codes/job/stack-os-matrix/label=centos-7,python=py2/15244//console
            https://ci.lsst.codes/job/stack-os-matrix/label=centos-6,python=py2/15244//console

            Show
            hchiang2 Hsin-Fang Chiang added a comment - Passed Jenkins, with lsst_ci : https://ci.lsst.codes/job/stack-os-matrix/label=centos-7,python=py2/15244//console https://ci.lsst.codes/job/stack-os-matrix/label=centos-6,python=py2/15244//console
            Hide
            Permalink
            hchiang2 Hsin-Fang Chiang added a comment -

            It seems that ci_hsc is not included in lsst_ci, so here are Jenkins for ci_hsc:
            https://ci.lsst.codes/job/stack-os-matrix/label=centos-7,python=py2/15250//console
            https://ci.lsst.codes/job/stack-os-matrix/label=centos-6,python=py2/15250//console

            Show
            hchiang2 Hsin-Fang Chiang added a comment - It seems that ci_hsc is not included in lsst_ci , so here are Jenkins for ci_hsc : https://ci.lsst.codes/job/stack-os-matrix/label=centos-7,python=py2/15250//console https://ci.lsst.codes/job/stack-os-matrix/label=centos-6,python=py2/15250//console
            Hide
            Permalink
            hchiang2 Hsin-Fang Chiang added a comment -

            Merged to master.

            Changes announced: https://community.lsst.org/t/logging-framework-transition/1114

            Show
            hchiang2 Hsin-Fang Chiang added a comment - Merged to master. Changes announced: https://community.lsst.org/t/logging-framework-transition/1114

              People

              Assignee:
              hchiang2 Hsin-Fang Chiang
              Reporter:
              hchiang2 Hsin-Fang Chiang
              Reviewers:
              Russell Owen
              Watchers:
              Hsin-Fang Chiang, Paul Price, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.