Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: sconsUtils
-
Labels:None
-
Story Points:0.5
-
Epic Link:
-
Sprint:DRP F16-2
-
Team:Data Release Production
Description
By default, our builds are not optimised (-O0), which requires everyone who doesn't want to wait until the heat death of the universe to set SCONSFLAGS="opt=3", but other packages that are built with scons may not recognise this. This default is also contrary to the standard practise for open-source software, which is that by default builds are optimised. I will change the default optimisation level to opt=3 from the current opt=0. I will also add support for -Og.
This change was approved in RFC-202.
Tim Jenness, would you review this please? I've implemented what I threatened, and observed that it works (-O3 is default, can set -Og). I also fixed the annoying error: no result from the compiler classifier.
price@price-laptop:~/LSST/sconsUtils (tickets/DM-7010=) $ git sub
commit b5e6e6106b33172be28b07195fe5b3c63323fda7
Author: Paul Price <price@astro.princeton.edu>
Date: Mon Jul 25 10:48:14 2016 -0400
set default optimisation level to 3
Our C++ code needs good optimisation to run efficiently, but this
was not set by default.
python/lsst/sconsUtils/state.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
commit b6cc932bcadb347e719aaa45d0d24e75e0488729
Author: Paul Price <price@astro.princeton.edu>
Date: Mon Jul 25 10:51:44 2016 -0400
add support for -Og
This optimisation flag is supported from gcc 4.8, and is apparently
useful for debugging C++ code.
python/lsst/sconsUtils/state.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
commit 29ad0e61099543c74249f1998e055ea5c6eab8a8
Author: Paul Price <price@astro.princeton.edu>
Date: Mon Jul 25 11:31:21 2016 -0400
ClassifyCc: fix "error: no result"
We weren't setting a result, so the default result ("error: no result")
was being used for us, which can confuse the user.
python/lsst/sconsUtils/state.py | 2 ++
1 file changed, 2 insertions(+)