Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7028

Port daf_base to Python 3

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: daf_base
    • Labels:
      None

      Description

      Changes necessary to get daf_base to work with Python 3.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7391 Port obs_monocam to Python 3

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7416 Port dax_imgserv to Python 3

          • Done
          is triggering

          Improvement - An improvement or enhancement to an existing feature or task. DM-7141 PropertyList Int type should be defined as 32-bit

          • To Do
          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Please would you review?

            Show
            tjenness Tim Jenness added a comment - Please would you review?
            Hide
            Permalink
            price Paul Price added a comment -

            Nothing major. Whitespace and style commits can probably all be squashed, and the SWIG int commits should be squashed.

            Show
            price Paul Price added a comment - Nothing major. Whitespace and style commits can probably all be squashed, and the SWIG int commits should be squashed.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Paul Price Can you take a quick look at the baseLib.i changes again please? I reworked them a bit and fixed a bad bug (was not checking for negative numbers, was not handling bool and was treating int as 64bit!). Now passes Jenkins.

            Show
            tjenness Tim Jenness added a comment - Paul Price Can you take a quick look at the baseLib.i changes again please? I reworked them a bit and fixed a bad bug (was not checking for negative numbers, was not handling bool and was treating int as 64bit!). Now passes Jenkins.
            Hide
            Permalink
            price Paul Price added a comment -

            Had another look, and made comments on the GitHub PR.

            Show
            price Paul Price added a comment - Had another look, and made comments on the GitHub PR.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Thanks for the great review. All changes implemented and extra tests added. Can build lsst_apps ok now.

            Show
            tjenness Tim Jenness added a comment - Thanks for the great review. All changes implemented and extra tests added. Can build lsst_apps ok now.

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Paul Price
              Watchers:
              J Matt Peterson [X] (Inactive), Paul Price, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.