Details

    • Type: Story
    • Status: Done
    • Priority: Major
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: daf_base
    • Labels:
      None
    • Templates:
    • Story Points:
      0.5
    • Team:
      Architecture

      Description

      Changes necessary to get daf_base to work with Python 3.

        Issue Links

          Activity

          Hide
          tjenness Tim Jenness added a comment -

          Please would you review?

          Show
          tjenness Tim Jenness added a comment - Please would you review?
          Hide
          price Paul Price added a comment -

          Nothing major. Whitespace and style commits can probably all be squashed, and the SWIG int commits should be squashed.

          Show
          price Paul Price added a comment - Nothing major. Whitespace and style commits can probably all be squashed, and the SWIG int commits should be squashed.
          Hide
          tjenness Tim Jenness added a comment -

          Paul Price Can you take a quick look at the baseLib.i changes again please? I reworked them a bit and fixed a bad bug (was not checking for negative numbers, was not handling bool and was treating int as 64bit!). Now passes Jenkins.

          Show
          tjenness Tim Jenness added a comment - Paul Price Can you take a quick look at the baseLib.i changes again please? I reworked them a bit and fixed a bad bug (was not checking for negative numbers, was not handling bool and was treating int as 64bit!). Now passes Jenkins.
          Hide
          price Paul Price added a comment -

          Had another look, and made comments on the GitHub PR.

          Show
          price Paul Price added a comment - Had another look, and made comments on the GitHub PR.
          Hide
          tjenness Tim Jenness added a comment -

          Thanks for the great review. All changes implemented and extra tests added. Can build lsst_apps ok now.

          Show
          tjenness Tim Jenness added a comment - Thanks for the great review. All changes implemented and extra tests added. Can build lsst_apps ok now.

            People

            • Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Paul Price
              Watchers:
              J Matt Peterson, Paul Price, Tim Jenness
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development