Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7044

Additional constraints on reference band selection for multiband

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_tasks
    • Labels:
      None
    • Story Points:
      3
    • Epic Link:
    • Sprint:
      DRP F16-3
    • Team:
      Data Release Production

      Description

      Reference band selection currently depends on the configured band priority order, with exceptions made for sources with low signal-to-noise in the high priority bands. HSC-1411 points out that some additional qualifications, such as success for major measurements (e.g., CModel and Kron), would be helpful.

        Attachments

          Issue Links

            Activity

            Hide
            price Paul Price added a comment -

            David Reiss, are you able to review this, please? It's not very large.

            pprice@tiger-sumire:~/LSST/pipe/tasks (tickets/DM-7044=) $ git sub
            commit a20f97c838a1ff413672bd339fd26758ee52bee9
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Wed Jul 27 18:13:18 2016 -0400
             
                multiband: add flag support for measurement merge
                
                Reference band selection previously looked at only the priority
                order and PSF S/N, but it would be helpful to also require that
                some flags aren't set (so we can insist it's not saturated, has
                a valid CModel or Kron flux, etc).
             
             python/lsst/pipe/tasks/multiBand.py | 13 ++++++++++++-
             1 file changed, 12 insertions(+), 1 deletion(-)
            

            Show
            price Paul Price added a comment - David Reiss , are you able to review this, please? It's not very large. pprice@tiger-sumire:~/LSST/pipe/tasks (tickets/DM-7044=) $ git sub commit a20f97c838a1ff413672bd339fd26758ee52bee9 Author: Paul Price <price@astro.princeton.edu> Date: Wed Jul 27 18:13:18 2016 -0400   multiband: add flag support for measurement merge Reference band selection previously looked at only the priority order and PSF S/N, but it would be helpful to also require that some flags aren't set (so we can insist it's not saturated, has a valid CModel or Kron flux, etc).   python/lsst/pipe/tasks/multiBand.py | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)
            Hide
            reiss David Reiss added a comment -

            All looks fine to me.

            Show
            reiss David Reiss added a comment - All looks fine to me.
            Hide
            price Paul Price added a comment -

            Thanks David Reiss.

            This passed Jenkins last night, so I've merged to master.

            Show
            price Paul Price added a comment - Thanks David Reiss . This passed Jenkins last night, so I've merged to master.

              People

              • Assignee:
                price Paul Price
                Reporter:
                price Paul Price
                Reviewers:
                David Reiss
                Watchers:
                David Reiss, Jim Bosch, Paul Price
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel