Details

    • Type: Story
    • Status: Done
    • Priority: Major
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_subaru
    • Labels:
      None
    • Templates:
    • Story Points:
      0.1
    • Epic Link:
    • Sprint:
      DRP F16-2
    • Team:
      Data Release Production

      Description

      This is a port of HSC-1397 to support reduction of observations with the new HSC-I2 filter. There is already support for reading that data, but we need a few config tweaks to allow processing it.

        Issue Links

          Activity

          Hide
          price Paul Price added a comment -

          Should be a simple cherry-pick.

          Show
          price Paul Price added a comment - Should be a simple cherry-pick.
          Hide
          price Paul Price added a comment -

          Nate Lust, would you please have a look at this simple patch?

          price@price-laptop:~/LSST/obs/subaru (tickets/DM-7045=) $ git sub-patch
          commit 2e4c58a58063033302f51ee2b60ce6724257fe85
          Author: Paul Price <price@astro.princeton.edu>
          Date:   Wed May 18 08:57:29 2016 -0400
           
              config: support HSC-I2 filter
           
          diff --git a/config/hsc/filterMap.py b/config/hsc/filterMap.py
          index 89f4b09..ed7a8b4 100644
          --- a/config/hsc/filterMap.py
          +++ b/config/hsc/filterMap.py
          @@ -1,2 +1,3 @@
          -for source, target in [("N921", 'z'), ("N816", 'i'), ("N515", 'g'), ("N387", 'g'), ("N1010", 'z')]:
          +for source, target in [("N921", 'z'), ("N816", 'i'), ("N515", 'g'), ("N387", 'g'), ("N1010", 'z')
          +                       ("i2", 'i'),]:
               config.filterMap[source] = target
          diff --git a/config/hsc/mergeCoaddDetections.py b/config/hsc/mergeCoaddDetections.py
          index dc04d73..36d9eb7 100644
          --- a/config/hsc/mergeCoaddDetections.py
          +++ b/config/hsc/mergeCoaddDetections.py
          @@ -1,2 +1,2 @@
          -root.priorityList = ["HSC-I", "HSC-R", "HSC-Z", "HSC-Y", "HSC-G", "NB0921", "NB0816", "NB1010", "NB0387", "NB0515",]
          +root.priorityList = ["HSC-I2", "HSC-I", "HSC-R", "HSC-Z", "HSC-Y", "HSC-G", "NB0921", "NB0816", "NB1010", "NB0387", "NB0515",]
           
          diff --git a/config/hsc/mergeCoaddMeasurements.py b/config/hsc/mergeCoaddMeasurements.py
          index dc04d73..36d9eb7 100644
          --- a/config/hsc/mergeCoaddMeasurements.py
          +++ b/config/hsc/mergeCoaddMeasurements.py
          @@ -1,2 +1,2 @@
          -root.priorityList = ["HSC-I", "HSC-R", "HSC-Z", "HSC-Y", "HSC-G", "NB0921", "NB0816", "NB1010", "NB0387", "NB0515",]
          +root.priorityList = ["HSC-I2", "HSC-I", "HSC-R", "HSC-Z", "HSC-Y", "HSC-G", "NB0921", "NB0816", "NB1010", "NB0387", "NB0515",]
           
          

          Show
          price Paul Price added a comment - Nate Lust , would you please have a look at this simple patch? price@price-laptop:~/LSST/obs/subaru (tickets/DM-7045=) $ git sub-patch commit 2e4c58a58063033302f51ee2b60ce6724257fe85 Author: Paul Price <price@astro.princeton.edu> Date: Wed May 18 08:57:29 2016 -0400   config: support HSC-I2 filter   diff --git a/config/hsc/filterMap.py b/config/hsc/filterMap.py index 89f4b09..ed7a8b4 100644 --- a/config/hsc/filterMap.py +++ b/config/hsc/filterMap.py @@ -1,2 +1,3 @@ -for source, target in [("N921", 'z'), ("N816", 'i'), ("N515", 'g'), ("N387", 'g'), ("N1010", 'z')]: +for source, target in [("N921", 'z'), ("N816", 'i'), ("N515", 'g'), ("N387", 'g'), ("N1010", 'z') + ("i2", 'i'),]: config.filterMap[source] = target diff --git a/config/hsc/mergeCoaddDetections.py b/config/hsc/mergeCoaddDetections.py index dc04d73..36d9eb7 100644 --- a/config/hsc/mergeCoaddDetections.py +++ b/config/hsc/mergeCoaddDetections.py @@ -1,2 +1,2 @@ -root.priorityList = ["HSC-I", "HSC-R", "HSC-Z", "HSC-Y", "HSC-G", "NB0921", "NB0816", "NB1010", "NB0387", "NB0515",] +root.priorityList = ["HSC-I2", "HSC-I", "HSC-R", "HSC-Z", "HSC-Y", "HSC-G", "NB0921", "NB0816", "NB1010", "NB0387", "NB0515",] diff --git a/config/hsc/mergeCoaddMeasurements.py b/config/hsc/mergeCoaddMeasurements.py index dc04d73..36d9eb7 100644 --- a/config/hsc/mergeCoaddMeasurements.py +++ b/config/hsc/mergeCoaddMeasurements.py @@ -1,2 +1,2 @@ -root.priorityList = ["HSC-I", "HSC-R", "HSC-Z", "HSC-Y", "HSC-G", "NB0921", "NB0816", "NB1010", "NB0387", "NB0515",] +root.priorityList = ["HSC-I2", "HSC-I", "HSC-R", "HSC-Z", "HSC-Y", "HSC-G", "NB0921", "NB0816", "NB1010", "NB0387", "NB0515",]
          Hide
          nlust Nate Lust added a comment -

          The changes look fine with me, with only one question (as I am ignorant of the specifics), are you sure the i2 should be at the top of the priority list? If so then all looks good to me.

          Show
          nlust Nate Lust added a comment - The changes look fine with me, with only one question (as I am ignorant of the specifics), are you sure the i2 should be at the top of the priority list? If so then all looks good to me.
          Hide
          price Paul Price added a comment -

          We put i2 at the top of the priority list on the HSC side, so this mirrors what we did there. We put it at the top of the list because it's a better filter than the original i filter (not that it makes much difference at the moment, because we're currently treating i and i2 as the same filter) and we've agreed that i-band is top priority (has better seeing and depth in the HSC SSP). That may not be optimal for observations other than the HSC SSP, but people can always modify it.

          Show
          price Paul Price added a comment - We put i2 at the top of the priority list on the HSC side, so this mirrors what we did there. We put it at the top of the list because it's a better filter than the original i filter (not that it makes much difference at the moment, because we're currently treating i and i2 as the same filter) and we've agreed that i-band is top priority (has better seeing and depth in the HSC SSP). That may not be optimal for observations other than the HSC SSP, but people can always modify it.
          Hide
          price Paul Price added a comment -

          Merged to master.

          Show
          price Paul Price added a comment - Merged to master.

            People

            • Assignee:
              price Paul Price
              Reporter:
              price Paul Price
              Reviewers:
              Nate Lust
              Watchers:
              Nate Lust, Paul Price
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development

                  Agile