Details

    • Type: Story
    • Status: Done
    • Priority: Major
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: daf_persistence
    • Labels:
      None
    • Templates:
    • Story Points:
      1
    • Team:
      Architecture

      Description

      Work relating to getting daf_persistence to run on python 3. Includes some code modernization.

        Issue Links

          Activity

          Hide
          tjenness Tim Jenness added a comment -

          Nate Pease can you please review my changes? They are needed before we can progress on the Python 3 port. I have made extensive cleanups to the code base as well and made it so the tests don't have to be run from the daf_persistence directory.

          I have one remaining test failure with butlerAlias.py where keys are being stored as bytes and not strings. I'm not entirely sure where in the code keys and values are stored in the dicts and why they would be bytes (bytes would be if the key comes from an external source). I'm not familiar enough with the code base to know where to look so your help would be much appreciated.

          Show
          tjenness Tim Jenness added a comment - Nate Pease can you please review my changes? They are needed before we can progress on the Python 3 port. I have made extensive cleanups to the code base as well and made it so the tests don't have to be run from the daf_persistence directory. I have one remaining test failure with butlerAlias.py where keys are being stored as bytes and not strings. I'm not entirely sure where in the code keys and values are stored in the dicts and why they would be bytes (bytes would be if the key comes from an external source). I'm not familiar enough with the code base to know where to look so your help would be much appreciated.
          Hide
          tjenness Tim Jenness added a comment -

          Merged.

          Show
          tjenness Tim Jenness added a comment - Merged.

            People

            • Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Nate Pease
              Watchers:
              Hsin-Fang Chiang, Nate Pease, Tim Jenness
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development