Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7117

measureCoaddSources fails with "RuntimeError: Unable to match sources"

    Details

    • Templates:
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      DRP F16-3, DRP F16-4
    • Team:
      Data Release Production

      Description

      Running measureCoaddSources.py, I'm getting a RuntimeError: Unable to match sources. The patch I'm running on doesn't have a lot of pixels illuminated, so it's not surprising that there would be no matches, but that fact shouldn't cause the operation to fail. The behaviour of the matcher has changed in this respect: before the refactoring of astrometry, AstrometryTask.useKnownWcs would not raise an exception, but log an error and return an empty list of matches (it successfully matched zero sources, which might be cause for concern).

      I think we should fix the matcher to return an empty list (as it did previously), but perhaps a case can be made that measureCoaddSources should catch the exception and continue. I think that's wrong because measureCoaddSources would have matches = None rather than an empty list, which communicates something different ("I have no knowledge of matches" vs "I tried to match and there's nothing"); and measureCoaddSources shouldn't simply set matches = [] because it's not its responsibility to guess a type for what its subtask returns (breaks encapsulation).

        Issue Links

          Activity

          Hide
          price Paul Price added a comment -

          Changes are in. I'm working on getting this to pass ci_hsc, and then will merge. Last chance to object!

          Show
          price Paul Price added a comment - Changes are in. I'm working on getting this to pass ci_hsc, and then will merge. Last chance to object!
          Hide
          price Paul Price added a comment -

          Jenkins passed. I'm about to merge.

          Show
          price Paul Price added a comment - Jenkins passed . I'm about to merge.
          Hide
          price Paul Price added a comment -

          Brain was on autopilot while merging: I neglected to squash the commits. Too eager to get it done, sorry.

          Merged to master stupidly. ):

          Show
          price Paul Price added a comment - Brain was on autopilot while merging: I neglected to squash the commits. Too eager to get it done, sorry. Merged to master stupidly. ):
          Hide
          swinbank John Swinbank added a comment -

          Paul Price, could you please add a brief comment on this to the release notes (https://confluence.lsstcorp.org/display/DM/Data+Release+Production+WIP+F16+Release+Notes)? Thanks.

          Show
          swinbank John Swinbank added a comment - Paul Price , could you please add a brief comment on this to the release notes ( https://confluence.lsstcorp.org/display/DM/Data+Release+Production+WIP+F16+Release+Notes)? Thanks.
          Hide
          price Paul Price added a comment -

          Done.

          Show
          price Paul Price added a comment - Done.

            People

            • Assignee:
              price Paul Price
              Reporter:
              price Paul Price
              Reviewers:
              Russell Owen
              Watchers:
              John Swinbank, Paul Price, Russell Owen
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development

                  Agile