[DM-7117] measureCoaddSources fails with "RuntimeError: Unable to match sources" - Jira

XML

Word

Printable

Details

Type: Bug
Status: Done
Resolution: Done
Fix Version/s: None
Component/s: meas_astrom, pipe_tasks
Labels:
- SciencePipelines

Story Points:
1
Epic Link:
f16-drp-bucket
Sprint:
DRP F16-3, DRP F16-4
Team:
Data Release Production

Description

Running measureCoaddSources.py, I'm getting a RuntimeError: Unable to match sources. The patch I'm running on doesn't have a lot of pixels illuminated, so it's not surprising that there would be no matches, but that fact shouldn't cause the operation to fail. The behaviour of the matcher has changed in this respect: before the refactoring of astrometry, AstrometryTask.useKnownWcs would not raise an exception, but log an error and return an empty list of matches (it successfully matched zero sources, which might be cause for concern).

I think we should fix the matcher to return an empty list (as it did previously), but perhaps a case can be made that measureCoaddSources should catch the exception and continue. I think that's wrong because measureCoaddSources would have matches = None rather than an empty list, which communicates something different ("I have no knowledge of matches" vs "I tried to match and there's nothing"); and measureCoaddSources shouldn't simply set matches = [] because it's not its responsibility to guess a type for what its subtask returns (breaks encapsulation).

Attachments

Issue Links

relates to

DM-8000 Error instantiating MultiBandDriverTask with LoadIndexedReferenceObjectsTask

Done

mentioned in: Page Loading...

Activity

Ascending order - Click to sort in descending order

Paul Price created issue - 03/Aug/16 12:55 PM

John Swinbank made changes - 04/Aug/16 5:32 AM

Field	Original Value	New Value
Assignee	Paul Price [ price ]

John Swinbank made changes - 04/Aug/16 5:33 AM

Team	Data Release Production [ 10301 ]
Labels		SciencePipelines

Paul Price made changes - 04/Aug/16 6:13 AM

Reviewers		Russell Owen [ rowen ]
Status	To Do [ 10001 ]	In Review [ 10004 ]

John Swinbank made changes - 04/Aug/16 6:56 AM

Epic Link

~~DM-6172~~ [ 24685 ]

John Swinbank made changes - 04/Aug/16 6:56 AM

Sprint		DRP F16-3 [ 237 ]
Team		Data Release Production [ 10301 ]

John Swinbank made changes - 04/Aug/16 12:12 PM

Assignee

Paul Price [ price ]

Russell Owen made changes - 09/Aug/16 1:57 PM

Status

In Review [ 10004 ]

Reviewed [ 10101 ]

Paul Price made changes - 09/Aug/16 6:42 PM

Status

Reviewed [ 10101 ]

In Review [ 10004 ]

Russell Owen made changes - 10/Aug/16 9:29 AM

Status

In Review [ 10004 ]

Reviewed [ 10101 ]

John Swinbank made changes - 01/Sep/16 3:03 PM

Sprint

DRP F16-3 [ 237 ]

DRP F16-3, DRP F16-4 [ 237, 246 ]

John Swinbank made changes - 01/Sep/16 3:03 PM

Rank

Ranked higher

Paul Price made changes - 02/Sep/16 11:46 AM

Resolution		Done [ 10000 ]
Status	Reviewed [ 10101 ]	Done [ 10002 ]

Paul Price made changes - 10/Oct/16 8:27 AM

Remote Link