Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7179

sconsUtils reads SConscript files in alphabetical order

        Details

        • Type: Bug
        • Status: Done
        • Priority: Major
        • Resolution: Done
        • Fix Version/s: None
        • Component/s: sconsUtils
        • Labels:
          None
        • Templates:
        • Story Points:
          1
        • Epic Link:
        • Sprint:
          DRP F16-3
        • Team:
          Data Release Production

          Description

          I have made the deeply embarrassing discovery that I knowingly made sconsUtils' reading of SConstruct files discovered in subdirectories ordered alphabetically, and considered this okay because "include < lib < python < test". This needs to be made user-configurable, probably via a keyword argument to sconsUtils.scripts.BasicSConstruct.

            Issue Links

            blocks

            Story - Created by JIRA Agile - do not edit or delete. Issue type for a user story. DM-6349 Replace cameraGeom PAF files

            • Major - Major loss of function.
            • In Progress
            mentioned in

            Page Loading...

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Parejkoj John Parejko added a comment -

              I believe the posted commit fixes the problem: I was able to remove the file-only dependency, add various Requires() in the base SConstruct, and the build order was obeyed.

              Show
              Parejkoj John Parejko added a comment - I believe the posted commit fixes the problem: I was able to remove the file-only dependency, add various Requires() in the base SConstruct, and the build order was obeyed.
              Hide
              Permalink
              jbosch Jim Bosch added a comment -

              John Parejko, could you please review this, and try the latest version on your test case?

              Show
              jbosch Jim Bosch added a comment - John Parejko , could you please review this, and try the latest version on your test case?
              Hide
              Permalink
              Parejkoj John Parejko added a comment -

              Although I still need to put in Requires and Depends commands to ensure the right things are built at the right time (unsurprising), this does do what I need. I posted one comment about a section of the code. Looks good otherwise.

              Show
              Parejkoj John Parejko added a comment - Although I still need to put in Requires and Depends commands to ensure the right things are built at the right time (unsurprising), this does do what I need. I posted one comment about a section of the code. Looks good otherwise.
              Hide
              Permalink
              jbosch Jim Bosch added a comment -

              Merged to master.

              Show
              jbosch Jim Bosch added a comment - Merged to master.

                People

                • Assignee:
                  jbosch Jim Bosch
                  Reporter:
                  jbosch Jim Bosch
                  Reviewers:
                  John Parejko
                  Watchers:
                  Jim Bosch, John Parejko, Paul Price
                • Votes:
                  1 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development

                      Agile