Details

    • Type: Bug
    • Status: Done
    • Priority: Major
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_algorithms
    • Labels:
      None
    • Templates:
    • Story Points:
      1
    • Sprint:
      DRP F16-3
    • Team:
      Data Release Production

      Description

      Port HSC-1416 to prevent ZeroDivisionError in MeasureApCorrTask.

        Issue Links

          Activity

          Hide
          price Paul Price added a comment -

          Lauren MacArthur, are you able to review this, please? It's been reviewed on the HSC side, but there were some merge conflicts so it's probably best to have another look.

          This has passed Jenkins.

          price@price-laptop:~/LSST/meas/algorithms (tickets/DM-7180=) $ git sub
          commit 9b12f685a16dfe4f23b902292c9ef8569113d8d9
          Author: Paul Price <price@astro.princeton.edu>
          Date:   Thu Jul 14 18:37:38 2016 -0400
           
              measureApCorr: ignore NAN values
              
              A single NAN in the inputs can produce all-NAN outputs, so be
              careful to get them all.
           
           python/lsst/meas/algorithms/measureApCorr.py | 6 ++++--
           1 file changed, 4 insertions(+), 2 deletions(-)
           
          commit 091cf633de271d951a91e58080ac5e95ef8eff66
          Author: Paul Price <price@astro.princeton.edu>
          Date:   Thu Jul 14 18:44:05 2016 -0400
           
              measureApCorr: add plot of residuals
           
           python/lsst/meas/algorithms/measureApCorr.py | 70 +++++++++++++++++++++++++++-
           1 file changed, 69 insertions(+), 1 deletion(-)
           
          commit 5a92e7650f0fa00fff7df0d8fc1c8225364fce26
          Author: Paul Price <price@astro.princeton.edu>
          Date:   Tue Aug 9 13:34:15 2016 -0400
           
              measureApCorr: ignore sources with zero flux
              
              Zero flux in the measurement being corrected will cause a
              ZeroDivisionError which can bring everything down, so we
              need to catch this case.
           
           python/lsst/meas/algorithms/measureApCorr.py | 9 +++++++--
           1 file changed, 7 insertions(+), 2 deletions(-)
          

          Show
          price Paul Price added a comment - Lauren MacArthur , are you able to review this, please? It's been reviewed on the HSC side, but there were some merge conflicts so it's probably best to have another look. This has passed Jenkins . price@price-laptop:~/LSST/meas/algorithms (tickets/DM-7180=) $ git sub commit 9b12f685a16dfe4f23b902292c9ef8569113d8d9 Author: Paul Price <price@astro.princeton.edu> Date: Thu Jul 14 18:37:38 2016 -0400   measureApCorr: ignore NAN values A single NAN in the inputs can produce all-NAN outputs, so be careful to get them all.   python/lsst/meas/algorithms/measureApCorr.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)   commit 091cf633de271d951a91e58080ac5e95ef8eff66 Author: Paul Price <price@astro.princeton.edu> Date: Thu Jul 14 18:44:05 2016 -0400   measureApCorr: add plot of residuals   python/lsst/meas/algorithms/measureApCorr.py | 70 +++++++++++++++++++++++++++- 1 file changed, 69 insertions(+), 1 deletion(-)   commit 5a92e7650f0fa00fff7df0d8fc1c8225364fce26 Author: Paul Price <price@astro.princeton.edu> Date: Tue Aug 9 13:34:15 2016 -0400   measureApCorr: ignore sources with zero flux Zero flux in the measurement being corrected will cause a ZeroDivisionError which can bring everything down, so we need to catch this case.   python/lsst/meas/algorithms/measureApCorr.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
          Hide
          tjenness Tim Jenness added a comment -

          Looks fine. Don't we have a utility plot routine somewhere that we can call to reduce all the boiler plate in the plot function?

          Show
          tjenness Tim Jenness added a comment - Looks fine. Don't we have a utility plot routine somewhere that we can call to reduce all the boiler plate in the plot function?
          Hide
          price Paul Price added a comment -

          We don't have a utility plot routine, but I think someone once proposed something.

          I've made the tweak you requested on GitHub, and am now just running Jenkins on meas_algorithms just to verify I didn't screw it up. Will merge soon. Thanks for the review!

          Show
          price Paul Price added a comment - We don't have a utility plot routine, but I think someone once proposed something. I've made the tweak you requested on GitHub, and am now just running Jenkins on meas_algorithms just to verify I didn't screw it up. Will merge soon. Thanks for the review!
          Hide
          price Paul Price added a comment -

          Merged to master.

          Show
          price Paul Price added a comment - Merged to master.

            People

            • Assignee:
              price Paul Price
              Reporter:
              price Paul Price
              Reviewers:
              Tim Jenness
              Watchers:
              Lauren MacArthur, Paul Price, Tim Jenness
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development

                  Agile