Port datarel to Python 3
file() in lsst.cat should be open()
Please take a look at this in conjunction with the changes in ctrl_execute, which is ticket DM-7185.
The changes made were to update to python 3 (backwards compatible with python 2.y), ran pep8, flake8, and updated the pydoc.
I made one more commit to fix:
Fixed extraneous "is True" and "is False" conditionals.
Removed redundant references using list(keys())
Review complete with DM-7185
Fixed and merged.
Steve Pietrowicz as I mention on the PR, there seems to be some changes that were not implemented from the review but with no comment as to why they were ignored. Also, Hsin-Fang Chiang found a bug in her review that is still present after the merge.
Tim Jenness well, thanks for catching this. I went to find the pull request for this the night of the review changes I made in ctrl_execute, and didn't see one, but I realized that there were "is True", "is False" and list(keys()) issues that had not been pointed out yet, which I fixed. I'll look at this again.