Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7183

port of ctrl_orca to python 3

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Attachments

        Issue Links

          Activity

          Hide
          spietrowicz Steve Pietrowicz added a comment -

          Please take a look at this in conjunction with the changes in ctrl_execute, which is ticket DM-7185.

          The changes made were to update to python 3 (backwards compatible with python 2.y), ran pep8, flake8, and updated the pydoc.

          Show
          spietrowicz Steve Pietrowicz added a comment - Please take a look at this in conjunction with the changes in ctrl_execute, which is ticket DM-7185 . The changes made were to update to python 3 (backwards compatible with python 2.y), ran pep8, flake8, and updated the pydoc.
          Hide
          spietrowicz Steve Pietrowicz added a comment -

          I made one more commit to fix:

          Fixed extraneous "is True" and "is False" conditionals.
          Removed redundant references using list(keys())

          Show
          spietrowicz Steve Pietrowicz added a comment - I made one more commit to fix: Fixed extraneous "is True" and "is False" conditionals. Removed redundant references using list(keys())
          Hide
          hchiang2 Hsin-Fang Chiang added a comment -

          Review complete with DM-7185

          Show
          hchiang2 Hsin-Fang Chiang added a comment - Review complete with DM-7185
          Hide
          spietrowicz Steve Pietrowicz added a comment -

          Fixed and merged.

          Show
          spietrowicz Steve Pietrowicz added a comment - Fixed and merged.
          Hide
          tjenness Tim Jenness added a comment -

          Steve Pietrowicz as I mention on the PR, there seems to be some changes that were not implemented from the review but with no comment as to why they were ignored. Also, Hsin-Fang Chiang found a bug in her review that is still present after the merge.

          Show
          tjenness Tim Jenness added a comment - Steve Pietrowicz as I mention on the PR, there seems to be some changes that were not implemented from the review but with no comment as to why they were ignored. Also, Hsin-Fang Chiang found a bug in her review that is still present after the merge.
          Hide
          spietrowicz Steve Pietrowicz added a comment -

          Tim Jenness well, thanks for catching this. I went to find the pull request for this the night of the review changes I made in ctrl_execute, and didn't see one, but I realized that there were "is True", "is False" and list(keys()) issues that had not been pointed out yet, which I fixed. I'll look at this again.

          Show
          spietrowicz Steve Pietrowicz added a comment - Tim Jenness well, thanks for catching this. I went to find the pull request for this the night of the review changes I made in ctrl_execute, and didn't see one, but I realized that there were "is True", "is False" and list(keys()) issues that had not been pointed out yet, which I fixed. I'll look at this again.

            People

            • Assignee:
              spietrowicz Steve Pietrowicz
              Reporter:
              spietrowicz Steve Pietrowicz
              Reviewers:
              Hsin-Fang Chiang
              Watchers:
              Hsin-Fang Chiang, Steve Pietrowicz, Tim Jenness
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel