Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7185

port of ctrl_execute to python 3

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Attachments

        Issue Links

          Activity

          Hide
          spietrowicz Steve Pietrowicz added a comment -

          Please look at this in conjunction with the changes made to ctrl_orca, ticket DM-1783.

          Changes here were made to update to python 3 (backwards compatible with python2.7), and ran pep8 and flake8.

          If you have an questions please feel free to ask.

          Show
          spietrowicz Steve Pietrowicz added a comment - Please look at this in conjunction with the changes made to ctrl_orca, ticket DM-1783 . Changes here were made to update to python 3 (backwards compatible with python2.7), and ran pep8 and flake8. If you have an questions please feel free to ask.
          Hide
          spietrowicz Steve Pietrowicz added a comment -

          Fixed extraneous "is True" and "is False" conditionals.
          Removed redundant references using list(keys())

          Show
          spietrowicz Steve Pietrowicz added a comment - Fixed extraneous "is True" and "is False" conditionals. Removed redundant references using list(keys())
          Hide
          hchiang2 Hsin-Fang Chiang added a comment -

          Overall the changes seem fine to me. Some more cleanup to do; see the comments on the PR (mostly from Tim Jenness). Unfortunately the recent Github changes are not helping at all and it seems difficult to track the comments v.s. code changes....

          I tried submitting a runOrca job on lsst-dev with this ticket branch, DM-7183, and a python 2 stack; the job started fine. I didn't verify beyond seeing some output data are generated.

          Show
          hchiang2 Hsin-Fang Chiang added a comment - Overall the changes seem fine to me. Some more cleanup to do; see the comments on the PR (mostly from Tim Jenness ). Unfortunately the recent Github changes are not helping at all and it seems difficult to track the comments v.s. code changes.... I tried submitting a runOrca job on lsst-dev with this ticket branch, DM-7183 , and a python 2 stack; the job started fine. I didn't verify beyond seeing some output data are generated.
          Hide
          spietrowicz Steve Pietrowicz added a comment -

          Thanks, made those changes last night and pushed them.

          I merged to master just now, and immediately realized that there may have been some lingering lsst10 references that needed to be changed to lsst-db. I fixed and pushed those too.

          Show
          spietrowicz Steve Pietrowicz added a comment - Thanks, made those changes last night and pushed them. I merged to master just now, and immediately realized that there may have been some lingering lsst10 references that needed to be changed to lsst-db. I fixed and pushed those too.

            People

            Assignee:
            spietrowicz Steve Pietrowicz
            Reporter:
            spietrowicz Steve Pietrowicz
            Reviewers:
            Hsin-Fang Chiang
            Watchers:
            Hsin-Fang Chiang, Steve Pietrowicz
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.