Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7221

TUNIT header is not uniformly applied to columns in FITS table output from afw.table

    Details

    • Type: Bug
    • Status: Done
    • Priority: Major
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
    • Templates:
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      DRP F16-3
    • Team:
      Data Release Production

      Description

      In looking at the Source table outputs (SRC*.fits files) in the validation_data_hsc repository, we noticed that the headers are not consistently applied in the FITS files generated by afw.table output. In particular, the TUNIT keywords are missing for the coord_ra and coord_dec columns, making it difficult for a client to determine that the columns are persisted in units of radians, especially since the FITS convention is for the default units for angles to be degrees.

      KEYWORD: TUNITn
      REFERENCE: FITS Standard
      STATUS: reserved
      HDU: table
      VALUE: string
      COMMENT: column units
      DEFINITION: The value field shall contain a character string describing
      the physical units in which the quantity in field n, after any
      application of TSCALn and TZEROn, is expressed. The units of all FITS
      header keyword values, with the exception of measurements of angles,
      should conform with the recommendations in the IAU Style Manual. For
      angular measurements given as floating point values and specified with
      reserved keywords, degrees are the recommended units (with the units,
      if specified, given as 'deg').

      http://heasarc.gsfc.nasa.gov/docs/fcg/standard_dict.html

      Accepting that we are not conforming to that convention, the proper value for TUNITn is "rad" for data in units of radians.

      While much access to afw.table-produced files will be through the afw.table interfaces, where this issue is irrelevant as long as round-tripping is successful, for exploratory and debugging purposes it is very useful to be able to access the file contents with standard tools.

      In addition, if the FITS tables produced from afw.table are to be used as the input to the database ingest, providing units for all columns will assist the database system in providing and validating correct column metadata to its clients, whether through VO standards or other means.

        Attachments

          Container Issues

            Issue Links

              Activity

                People

                • Assignee:
                  jbosch Jim Bosch
                  Reporter:
                  gpdf Gregory Dubois-Felsmann
                  Reviewers:
                  John Parejko
                  Watchers:
                  Gregory Dubois-Felsmann, Jim Bosch, John Parejko, John Swinbank, Loi Ly, Nate Pease, Paul Price, Pim Schellart, Trey Roby
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  9 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Summary Panel