Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7221

TUNIT header is not uniformly applied to columns in FITS table output from afw.table

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      DRP F16-3
    • Team:
      Data Release Production

      Description

      In looking at the Source table outputs (SRC*.fits files) in the validation_data_hsc repository, we noticed that the headers are not consistently applied in the FITS files generated by afw.table output. In particular, the TUNIT keywords are missing for the coord_ra and coord_dec columns, making it difficult for a client to determine that the columns are persisted in units of radians, especially since the FITS convention is for the default units for angles to be degrees.

      KEYWORD: TUNITn
      REFERENCE: FITS Standard
      STATUS: reserved
      HDU: table
      VALUE: string
      COMMENT: column units
      DEFINITION: The value field shall contain a character string describing
      the physical units in which the quantity in field n, after any
      application of TSCALn and TZEROn, is expressed. The units of all FITS
      header keyword values, with the exception of measurements of angles,
      should conform with the recommendations in the IAU Style Manual. For
      angular measurements given as floating point values and specified with
      reserved keywords, degrees are the recommended units (with the units,
      if specified, given as 'deg').

      http://heasarc.gsfc.nasa.gov/docs/fcg/standard_dict.html

      Accepting that we are not conforming to that convention, the proper value for TUNITn is "rad" for data in units of radians.

      While much access to afw.table-produced files will be through the afw.table interfaces, where this issue is irrelevant as long as round-tripping is successful, for exploratory and debugging purposes it is very useful to be able to access the file contents with standard tools.

      In addition, if the FITS tables produced from afw.table are to be used as the input to the database ingest, providing units for all columns will assist the database system in providing and validating correct column metadata to its clients, whether through VO standards or other means.

        Attachments

          Issue Links

            Activity

            gpdf Gregory Dubois-Felsmann created issue -
            gpdf Gregory Dubois-Felsmann made changes -
            Field Original Value New Value
            Link This issue relates to DM-7222 [ DM-7222 ]
            jbosch Jim Bosch made changes -
            Assignee Jim Bosch [ jbosch ]
            jbosch Jim Bosch made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            swinbank John Swinbank made changes -
            Epic Link DM-6172 [ 24685 ]
            swinbank John Swinbank made changes -
            Sprint DRP F16-3 [ 237 ]
            Story Points 1
            jbosch Jim Bosch made changes -
            Reviewers John Parejko [ parejkoj ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            jbosch Jim Bosch made changes -
            Status In Review [ 10004 ] In Progress [ 3 ]
            jbosch Jim Bosch made changes -
            Status In Progress [ 3 ] In Review [ 10004 ]
            Parejkoj John Parejko made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            jbosch Jim Bosch made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            lauren Lauren MacArthur made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            lauren Lauren MacArthur made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            rhl Robert Lupton made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            rhl Robert Lupton made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            rhl Robert Lupton made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            rhl Robert Lupton made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            price Paul Price made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            price Paul Price made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            pschella Pim Schellart [X] (Inactive) made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            pschella Pim Schellart [X] (Inactive) made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            pschella Pim Schellart [X] (Inactive) made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            pschella Pim Schellart [X] (Inactive) made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            rhl Robert Lupton made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            rhl Robert Lupton made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            jbosch Jim Bosch made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            jbosch Jim Bosch made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            rowen Russell Owen made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            rowen Russell Owen made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            rowen Russell Owen made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            rowen Russell Owen made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            krzys Krzysztof Findeisen made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            krzys Krzysztof Findeisen made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14269 ] This issue links to "Page (Confluence)" [ 14269 ]

              People

              • Assignee:
                jbosch Jim Bosch
                Reporter:
                gpdf Gregory Dubois-Felsmann
                Reviewers:
                John Parejko
                Watchers:
                Gregory Dubois-Felsmann, Jim Bosch, John Parejko, John Swinbank, Loi Ly, Nate Pease, Paul Price, Pim Schellart [X] (Inactive), Trey Roby
              • Votes:
                0 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel