Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7244

Port obs_test to Python 3 and modernize unit tests

    Details

      Attachments

        Issue Links

          Activity

          Hide
          rowen Russell Owen added a comment - - edited

          Jenkins Python 2 ran. Cannot test with Python 3 until all dependencies have been converted.

          Show
          rowen Russell Owen added a comment - - edited Jenkins Python 2 ran. Cannot test with Python 3 until all dependencies have been converted.
          Hide
          tjenness Tim Jenness added a comment -

          Looks good. I have some concern over the pickle binary mode and there is one test that needs fixing to understand where its data file is located.

          Show
          tjenness Tim Jenness added a comment - Looks good. I have some concern over the pickle binary mode and there is one test that needs fixing to understand where its data file is located.
          Hide
          rowen Russell Owen added a comment - - edited

          Thank you for the review. I updated the repo accordingly and will merge after a Jenkins run.

          Note that the pickle in question was due to an outdated bin.src script which I removed.

          Show
          rowen Russell Owen added a comment - - edited Thank you for the review. I updated the repo accordingly and will merge after a Jenkins run. Note that the pickle in question was due to an outdated bin.src script which I removed.
          Hide
          rowen Russell Owen added a comment -

          I also added one missing _all_ =. .. and modernized one import of numpy

          Show
          rowen Russell Owen added a comment - I also added one missing _ all _ =. .. and modernized one import of numpy

            People

            • Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Tim Jenness
              Watchers:
              Russell Owen, Tim Jenness
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel