# port tests in ctrl_events to use pytest

XMLWordPrintable

## Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s: None
• Labels:
None
• Story Points:
2
• Team:
Data Facility

## Description

https://developer.lsst.io/coding/python_testing.html

The changes in this ticket are updating the tests so they run as standalone tests, and so they also work with py.test

## Activity

Hide
Matias Carrasco Kind added a comment -

thanks Tim Jenness, that's what I thought it'd be the case

Show
Matias Carrasco Kind added a comment - thanks Tim Jenness , that's what I thought it'd be the case
Hide
Tim Jenness added a comment -

Hmmm

 * 26e4a26 - (HEAD -> tickets/DM-7252, origin/tickets/DM-7252) Merge branch 'tickets/DM-7252' of ssh://github.com/lsst/ctrl_events into tickets/DM-7252 (11 minutes ago)  |\  | * d8cf6e4 - Add tests/.cache to .gitignore (18 hours ago)  | * 3f20ea6 - Merge branch 'tickets/DM-7252' of ssh://github.com/lsst/ctrl_events into tickets/DM-7252 (18 hours ago)  | |\  | * | 57316fa - Added reset() method to LocationId() to allow reset of localId, which came up because of the way py.test tests things Removed extraneous print statements Updated tests that used LocationId to reset the value before running. (18 hours ago)  * | | 1abc3cd - Add tests/.cache to .gitignore (12 minutes ago)  | |/  |/|  * | f7d5c9f - Remove all MakeSuite references change over to inherit from lsst.utils.tests instead of unittest (6 days ago) 

Do you want me to have a go?

Show
Tim Jenness added a comment - Hmmm * 26e4a26 - (HEAD -> tickets/DM-7252, origin/tickets/DM-7252) Merge branch 'tickets/DM-7252' of ssh://github.com/lsst/ctrl_events into tickets/DM-7252 (11 minutes ago) |\ | * d8cf6e4 - Add tests/.cache to .gitignore (18 hours ago) | * 3f20ea6 - Merge branch 'tickets/DM-7252' of ssh://github.com/lsst/ctrl_events into tickets/DM-7252 (18 hours ago) | |\ | * | 57316fa - Added reset() method to LocationId() to allow reset of localId, which came up because of the way py.test tests things Removed extraneous print statements Updated tests that used LocationId to reset the value before running. (18 hours ago) * | | 1abc3cd - Add tests/.cache to .gitignore (12 minutes ago) | |/ |/| * | f7d5c9f - Remove all MakeSuite references change over to inherit from lsst.utils.tests instead of unittest (6 days ago) Do you want me to have a go?
Hide
Steve Pietrowicz added a comment -

If you could, that would be great! And if you can tell me what I should have done, I would appreciate it.

I originally did a rebase with pick/skip/skip which looked ok from here, and then did a pull, which might have screwed things up.

Show
Steve Pietrowicz added a comment - If you could, that would be great! And if you can tell me what I should have done, I would appreciate it. I originally did a rebase with pick/skip/skip which looked ok from here, and then did a pull, which might have screwed things up.
Hide
Tim Jenness added a comment -

I have force pushed a fixed up branch. git rebase master worked to remove the empty commits. I also fixed one of the commit messages that was lacking a blank line in line 2 and I have remove trailing whitespace. Please delete your local branch before pulling, otherwise you'll merge your local branch with my updated branch.

Show
Tim Jenness added a comment - I have force pushed a fixed up branch. git rebase master worked to remove the empty commits. I also fixed one of the commit messages that was lacking a blank line in line 2 and I have remove trailing whitespace. Please delete your local branch before pulling, otherwise you'll merge your local branch with my updated branch.
Hide
Steve Pietrowicz added a comment -

Thanks, Tim Jenness!

Merged to master.

$git push Counting objects: 1, done. Writing objects: 100% (1/1), 241 bytes | 0 bytes/s, done. Total 1 (delta 0), reused 0 (delta 0) To ssh://git@github.com/lsst/ctrl_events.git de48e12..8f06dbd master -> master Show Steve Pietrowicz added a comment - Thanks, Tim Jenness ! Merged to master.$ git push Counting objects: 1, done. Writing objects: 100% (1/1), 241 bytes | 0 bytes/s, done. Total 1 (delta 0), reused 0 (delta 0) To ssh://git@github.com/lsst/ctrl_events.git de48e12..8f06dbd master -> master

## People

• Assignee:
Steve Pietrowicz
Reporter:
Steve Pietrowicz
Reviewers:
Matias Carrasco Kind
Watchers:
Matias Carrasco Kind, Steve Pietrowicz, Tim Jenness