Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7258

Port coadd_utils to Python 3 and update unit tests for pytest

    Details

      Attachments

        Issue Links

          Activity

          Hide
          rowen Russell Owen added a comment -

          Running Jenkins on Python 2 now

          Show
          rowen Russell Owen added a comment - Running Jenkins on Python 2 now
          Hide
          rowen Russell Owen added a comment -

          I noticed that the tests have short doc module-level doc strings that seem redundant. I'm happy to remove them if wanted.

          Show
          rowen Russell Owen added a comment - I noticed that the tests have short doc module-level doc strings that seem redundant. I'm happy to remove them if wanted.
          Hide
          tjenness Tim Jenness added a comment -

          Minor comment on variable names for data dir. Otherwise looks great. It's amazing how few changes are needed for python 3.

          Show
          tjenness Tim Jenness added a comment - Minor comment on variable names for data dir. Otherwise looks great. It's amazing how few changes are needed for python 3.
          Hide
          rowen Russell Owen added a comment -

          I tweaked the two tests that you commented on, but not in exactly the way you suggested. Please have a quick look and see if it's OK.

          Show
          rowen Russell Owen added a comment - I tweaked the two tests that you commented on, but not in exactly the way you suggested. Please have a quick look and see if it's OK.
          Hide
          tjenness Tim Jenness added a comment -

          That's fine. Is consistent now. Thanks.

          Show
          tjenness Tim Jenness added a comment - That's fine. Is consistent now. Thanks.
          Hide
          rowen Russell Owen added a comment -

          Great! I'm glad you were happy with the change. I agree it is an improvement.

          Show
          rowen Russell Owen added a comment - Great! I'm glad you were happy with the change. I agree it is an improvement.

            People

            • Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Tim Jenness
              Watchers:
              Russell Owen, Tim Jenness
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel