Details

    • Templates:

      Issue Links

        Activity

        Hide
        rowen Russell Owen added a comment - - edited

        Running on Jenkins for Python 2

        Show
        rowen Russell Owen added a comment - - edited Running on Jenkins for Python 2
        Hide
        tjenness Tim Jenness added a comment -

        Looks good. We can remove the with_statement future imports though.

        Show
        tjenness Tim Jenness added a comment - Looks good. We can remove the with_statement future imports though.
        Hide
        rowen Russell Owen added a comment -

        I took a cleanup pass and fixed the following:

        • added missing setupRequired("python_future") to the ups table file
        • added tests/.cache to .gitignore as per your suggestion
        • removed unneeded imports
        • standardized import order
        • fixed a few lines that were too long
        • changed a few == None to is None

        I'll merge after a successful Jenkins run

        Show
        rowen Russell Owen added a comment - I took a cleanup pass and fixed the following: added missing setupRequired("python_future") to the ups table file added tests/.cache to .gitignore as per your suggestion removed unneeded imports standardized import order fixed a few lines that were too long changed a few == None to is None I'll merge after a successful Jenkins run

          People

          • Assignee:
            rowen Russell Owen
            Reporter:
            rowen Russell Owen
            Reviewers:
            Tim Jenness
            Watchers:
            Russell Owen, Tim Jenness
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development