Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7262

Port meas_base to Python 3

    XMLWordPrintable

    Details

      Attachments

        Issue Links

        blocks

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7289 Port meas_algorithms to python 3

        • Done

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7292 Port pipe_tasks to Python 3

        • Done

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7293 Port meas_modelfit to Python 3

        • Done

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7297 Port ip_diffim to Python 3

        • Done

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7300 Port meas_extensions_photometryKron to Python 3

        • Done

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7301 Port meas_extensions_simpleShape to python 3

        • Done

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7302 Port meas_extensions_psfex to Python 3

        • Done

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7304 Port meas_extensions_shapeHSM to Python 3

        • Done

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7307 Port obs_decam to Python 3

        • Done

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7325 Port meas_extensions_ngmix to Python 3

        • Done
        duplicates

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-4011 Rename forced photometry CmdLineTasks to match bin scripts

        • Invalid
        is blocked by

        Bug - A problem which impairs or prevents the functions of the product. DM-7337 ChoiceField requires unicode strings

        • Done

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7229 Modify meas base tests to support pytest

        • Done
        mentioned in

        Page Loading...

          Activity

          Ascending order - Click to sort in descending order
          No builds found.
          rowen Russell Owen created issue -
          rowen Russell Owen made changes -
          Field Original Value New Value
          Link This issue is blocked by DM-7229 [ DM-7229 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ]
          price Paul Price made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          rowen Russell Owen made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          jmatt J Matt Peterson [X] (Inactive) made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          nlust Nate Lust made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          tjenness Tim Jenness made changes -
          Link This issue blocks DM-7304 [ DM-7304 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          tjenness Tim Jenness made changes -
          Link This issue blocks DM-7325 [ DM-7325 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          tjenness Tim Jenness made changes -
          Link This issue blocks DM-7289 [ DM-7289 ]
          tjenness Tim Jenness made changes -
          Link This issue blocks DM-7300 [ DM-7300 ]
          tjenness Tim Jenness made changes -
          Link This issue blocks DM-7301 [ DM-7301 ]
          tjenness Tim Jenness made changes -
          Link This issue blocks DM-7302 [ DM-7302 ]
          tjenness Tim Jenness made changes -
          Link This issue blocks DM-7293 [ DM-7293 ]
          tjenness Tim Jenness made changes -
          Link This issue blocks DM-7292 [ DM-7292 ]
          tjenness Tim Jenness made changes -
          Link This issue blocks DM-7297 [ DM-7297 ]
          tjenness Tim Jenness made changes -
          Link This issue blocks DM-7307 [ DM-7307 ]
          rowen Russell Owen made changes -
          Status To Do [ 10001 ] In Progress [ 3 ]
          rowen Russell Owen made changes -
          Link This issue relates to DM-7337 [ DM-7337 ]
          nlust Nate Lust made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          rowen Russell Owen made changes -
          Link This issue is blocked by DM-7337 [ DM-7337 ]
          rowen Russell Owen made changes -
          Link This issue relates to DM-7337 [ DM-7337 ]
          Hide
          Permalink
          rowen Russell Owen added a comment -

          This code relies on a change in pex_config DM-7337.

          One possibly surprising change is renaming ProcessImageForcedTask/Config to ForcedPhotImageTask/Config. This makes the code more self-consistent (including fixing at least one bug) and Jim Bosch confirmed that the best way out was the one I took. See the relevant commit message for more information.

          Show
          rowen Russell Owen added a comment - This code relies on a change in pex_config DM-7337 . One possibly surprising change is renaming ProcessImageForcedTask/Config to ForcedPhotImageTask/Config. This makes the code more self-consistent (including fixing at least one bug) and Jim Bosch confirmed that the best way out was the one I took. See the relevant commit message for more information.
          rowen Russell Owen made changes -
          Status In Progress [ 3 ] In Review [ 10004 ]
          Reviewers Nate Lust [ nlust ]
          rowen Russell Owen made changes -
          Reviewers Nate Lust [ nlust ] Tim Jenness [ tjenness ]
          Hide
          Permalink
          tjenness Tim Jenness added a comment -

          Looks great. Minor comments on the PR. One of the commits refers to .bak files but the actual commit seems to be the futurize -2 phase.

          Show
          tjenness Tim Jenness added a comment - Looks great. Minor comments on the PR. One of the commits refers to .bak files but the actual commit seems to be the futurize -2 phase.
          tjenness Tim Jenness made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          Hide
          Permalink
          rowen Russell Owen added a comment -

          Thanks for the suggestions. I updated accordingly and am now running CI

          Show
          rowen Russell Owen added a comment - Thanks for the suggestions. I updated accordingly and am now running CI
          rowen Russell Owen made changes -
          Status Reviewed [ 10101 ] Reviewed [ 10101 ]
          rowen Russell Owen made changes -
          Comment [ This looks good to me. I verified that it is possible to override Choice entries from the command line (by tweaking pipe_base examples/argumentParser.py to add a choice field) and that the new unit test fails with the old code. The test could be expanded to make a Config and run validate and such on it, but given that the test fails with the old code, it probably suffices. ]
          rowen Russell Owen made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]
          swinbank John Swinbank made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          swinbank John Swinbank made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          fred3m Fred Moolekamp made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          fred3m Fred Moolekamp made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          fred3m Fred Moolekamp made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          fred3m Fred Moolekamp made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          fred3m Fred Moolekamp made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          Parejkoj John Parejko made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          Parejkoj John Parejko made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          spietrowicz Steve Pietrowicz made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          rowen Russell Owen made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          rowen Russell Owen made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14215 ] This issue links to "Page (Confluence)" [ 14215 ]
          yusra Yusra AlSayyad made changes -
          Link This issue duplicates DM-4011 [ DM-4011 ]

            People

            Assignee:
            rowen Russell Owen
            Reporter:
            rowen Russell Owen
            Reviewers:
            Tim Jenness
            Watchers:
            Nate Lust, Russell Owen, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.