Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7293

Port meas_modelfit to Python 3

    XMLWordPrintable

    Details

      Attachments

        Issue Links

        is blocked by

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7152 Port afw to Python 3

        • Done

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7256 Port Shapelet to Python 3

        • Done

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7262 Port meas_base to Python 3

        • Done

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7289 Port meas_algorithms to python 3

        • Done

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7292 Port pipe_tasks to Python 3

        • Done

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7358 Modify meas_modelfit tests to support pytest

        • Done
        relates to

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8528 Port jointcal to python 3

        • Done

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8243 Add python tests for string/byte BaseRecord getters/setters to aid pybind11

        • Invalid

        Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. DM-6179 Support Python 3 migration

        • Done
        mentioned in

        Page Loading...

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          Parejkoj John Parejko added a comment -

          Doing this, so we can be done with the python3 port!

          Show
          Parejkoj John Parejko added a comment - Doing this, so we can be done with the python3 port!
          Hide
          Permalink
          Parejkoj John Parejko added a comment -

          Fred: can you please review this quickly? Note that there is a SWIG addition in afw, which may not be ideal, but should be enough to make things work for now. We'll want a pybind11 version of those methods, and some unittests to go with them eventually.

          Once this is done, the last step is obs_subaru, which I've already ported but it failed when running a modelfit test...

          Show
          Parejkoj John Parejko added a comment - Fred: can you please review this quickly? Note that there is a SWIG addition in afw, which may not be ideal, but should be enough to make things work for now. We'll want a pybind11 version of those methods, and some unittests to go with them eventually. Once this is done, the last step is obs_subaru, which I've already ported but it failed when running a modelfit test...
          Hide
          Permalink
          fred3m Fred Moolekamp added a comment -

          Looks good to me. I noticed that you removed a couple of shebangs, is that standard procedure now, or is that something that was done automatically?

          You should probably open a ticket to cover adding tests for the setting strings in afw table. I'm wrapping that in pybind11 right now and noticed that there are no tests available for setting strings, but I think that the code should be much easier in pybind11 than SWIG and once a test is in place the pybind11 stack can be modified.

          Show
          fred3m Fred Moolekamp added a comment - Looks good to me. I noticed that you removed a couple of shebangs, is that standard procedure now, or is that something that was done automatically? You should probably open a ticket to cover adding tests for the setting strings in afw table. I'm wrapping that in pybind11 right now and noticed that there are no tests available for setting strings, but I think that the code should be much easier in pybind11 than SWIG and once a test is in place the pybind11 stack can be modified.
          Hide
          Permalink
          Parejkoj John Parejko added a comment -

          The shebangs I removed were from code not in bin/, so I don't see how they do any good anyway: that code can't really be executed as it's designed for import. I'm not sure that there is any policy on it either way.

          I added DM-8243 and put you on the watch list, Fred.

          Jenkins py2/3 lsst_py3 pass for the record, after rebasing afw: https://ci.lsst.codes/job/stack-os-matrix/18099/

          Show
          Parejkoj John Parejko added a comment - The shebangs I removed were from code not in bin/, so I don't see how they do any good anyway: that code can't really be executed as it's designed for import. I'm not sure that there is any policy on it either way. I added DM-8243 and put you on the watch list, Fred. Jenkins py2/3 lsst_py3 pass for the record, after rebasing afw: https://ci.lsst.codes/job/stack-os-matrix/18099/
          Hide
          Permalink
          Parejkoj John Parejko added a comment -

          Thanks for such a fast review, Fred. Merged and done.

          Show
          Parejkoj John Parejko added a comment - Thanks for such a fast review, Fred. Merged and done.

            People

            Assignee:
            Parejkoj John Parejko
            Reporter:
            tjenness Tim Jenness
            Reviewers:
            Fred Moolekamp
            Watchers:
            Fred Moolekamp, John Parejko, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.