Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7294

Update esutil to version that works on Python 3

    Details

    • Templates:
    • Story Points:
      1

      Issue Links

        Activity

        Hide
        tjenness Tim Jenness added a comment -

        See https://github.com/esheldon/esutil/issues/17

        It looks like v0.6.0 is now out and compatible with python 3: https://github.com/esheldon/esutil/releases/tag/v0.6.0

        Show
        tjenness Tim Jenness added a comment - See https://github.com/esheldon/esutil/issues/17 It looks like v0.6.0 is now out and compatible with python 3: https://github.com/esheldon/esutil/releases/tag/v0.6.0
        Hide
        tjenness Tim Jenness added a comment -

        Builds fine for me on python 3. Please remember to tag it when you merge.

        Show
        tjenness Tim Jenness added a comment - Builds fine for me on python 3. Please remember to tag it when you merge.
        Hide
        nlust Nate Lust added a comment -

        What tag are you referring to? the eups version tag? I am not sure how to do that.

        Show
        nlust Nate Lust added a comment - What tag are you referring to? the eups version tag? I am not sure how to do that.
        Hide
        tjenness Tim Jenness added a comment - - edited

        $ git checkout master
        $ git merge --no-ff tickets/DM-7294
        $ git push
        $ git tag -a 0.6.0
        $ git push --tags
        

        Standard process for working with third party packages: https://developer.lsst.io/build-ci/third_party.html#distributing-the-package

        Show
        tjenness Tim Jenness added a comment - - edited $ git checkout master $ git merge --no-ff tickets/DM-7294 $ git push $ git tag -a 0.6.0 $ git push --tags Standard process for working with third party packages: https://developer.lsst.io/build-ci/third_party.html#distributing-the-package
        Hide
        nlust Nate Lust added a comment -

        ah ok, its just a git tag, good to know. I will read over the link before merging just to be sure I cover everything

        Show
        nlust Nate Lust added a comment - ah ok, its just a git tag, good to know. I will read over the link before merging just to be sure I cover everything
        Hide
        swinbank John Swinbank added a comment -

        Changes look ok. But...

        I noticed all this guff in eupspkg.cfg.sh. This seems like it's unnecessary, since esutil 0.6 doesn't ship with its own table file as far as I can see. Can we drop it?

        Show
        swinbank John Swinbank added a comment - Changes look ok. But... I noticed all this guff in eupspkg.cfg.sh . This seems like it's unnecessary, since esutil 0.6 doesn't ship with its own table file as far as I can see. Can we drop it?
        Hide
        nlust Nate Lust added a comment -

        I checked into this as well, and ran it through ci with the prep function removed. If you agree with the latest change then I will merge.

        Show
        nlust Nate Lust added a comment - I checked into this as well, and ran it through ci with the prep function removed. If you agree with the latest change then I will merge.
        Hide
        nlust Nate Lust added a comment -

        merged to master

        Show
        nlust Nate Lust added a comment - merged to master

          People

          • Assignee:
            nlust Nate Lust
            Reporter:
            tjenness Tim Jenness
            Reviewers:
            John Swinbank
            Watchers:
            John Swinbank, Nate Lust, Simon Krughoff, Tim Jenness
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development