Details

    • Templates:
    • Story Points:
      2
    • Sprint:
      Alert Production F16 - 9
    • Team:
      Alert Production

      Description

      The current release of astrometry.net does not support Python 3. Upstream needs to be fixed.

        Issue Links

          Activity

          Hide
          Parejkoj John Parejko added a comment -

          I've created a PR for the makefile change I've made:

          https://github.com/dstndstn/astrometry.net/pull/90

          Show
          Parejkoj John Parejko added a comment - I've created a PR for the makefile change I've made: https://github.com/dstndstn/astrometry.net/pull/90
          Hide
          Parejkoj John Parejko added a comment -

          astrometry.net updated to 0.67 + Tim Jenness and my changes. Only builds the C portions (doesn't run make python or make extras), so outside code that depends on the python interface/scripts will almost certainly fail on python 3. But it's enough to make our meas_astrom tests pass.

          Show
          Parejkoj John Parejko added a comment - astrometry.net updated to 0.67 + Tim Jenness and my changes. Only builds the C portions (doesn't run make python or make extras ), so outside code that depends on the python interface/scripts will almost certainly fail on python 3. But it's enough to make our meas_astrom tests pass.
          Hide
          tjenness Tim Jenness added a comment - - edited

          I checked and those patch files were indeed not relevant any longer.

          I find it strange that I get told there are no clang patches to apply but that seems to have been saying that for ages.

          I have one main comment and that is I have no idea what version of astrometry.net this really contains. I would prefer it if we took the ngmix approach of including an upstream SHA1 in the version number of the file (and later tag). Also, since your Makefile patches have not (yet) been accepted by upstream we should include them explicitly in a patches directory. Otherwise, in a few months we will have no way of understanding which astrometry.net we are really using.

          Show
          tjenness Tim Jenness added a comment - - edited I checked and those patch files were indeed not relevant any longer. I find it strange that I get told there are no clang patches to apply but that seems to have been saying that for ages. I have one main comment and that is I have no idea what version of astrometry.net this really contains. I would prefer it if we took the ngmix approach of including an upstream SHA1 in the version number of the file (and later tag). Also, since your Makefile patches have not (yet) been accepted by upstream we should include them explicitly in a patches directory. Otherwise, in a few months we will have no way of understanding which astrometry.net we are really using.
          Hide
          Parejkoj John Parejko added a comment -

          The clang message is coming from eupspkg.cfg.sh. That line can probably be deleted, but I don't know what it's about.

          I've renamed the tarball and made it based on upstream master, and added a patchfile based on the Makefile changes against that. Rebuilding on Jenkins to be sure stuff is still happy.

          Show
          Parejkoj John Parejko added a comment - The clang message is coming from eupspkg.cfg.sh. That line can probably be deleted, but I don't know what it's about. I've renamed the tarball and made it based on upstream master, and added a patchfile based on the Makefile changes against that. Rebuilding on Jenkins to be sure stuff is still happy.
          Hide
          Parejkoj John Parejko added a comment -

          Merged! Multiple Jenkins runs passed.

          Show
          Parejkoj John Parejko added a comment - Merged! Multiple Jenkins runs passed.

            People

            • Assignee:
              Parejkoj John Parejko
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Tim Jenness
              Watchers:
              John Parejko, Simon Krughoff, Tim Jenness
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development

                  Agile