Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7297

Port ip_diffim to Python 3

    XMLWordPrintable

    Details

      Attachments

        Issue Links

        blocks

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7292 Port pipe_tasks to Python 3

        • Done
        is blocked by

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7152 Port afw to Python 3

        • Done

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7245 Port pipe_base to Python 3

        • Done

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7262 Port meas_base to Python 3

        • Done

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7289 Port meas_algorithms to python 3

        • Done

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7299 Check lmfit works with Python 3

        • Done

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7303 Port meas_deblender to Python 3

        • Done

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7320 Modify ip_diffim to support pytest

        • Done
        relates to

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7684 Clean up ip_diffim tests

        • To Do

        Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. DM-6179 Support Python 3 migration

        • Done
        mentioned in

        Page Loading...

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          mrawls Meredith Rawls added a comment -

          Started working on this.

          Show
          mrawls Meredith Rawls added a comment - Started working on this.
          Hide
          Permalink
          Parejkoj John Parejko added a comment -

          Please delete the ticket/DM-7297 (singular) branch to remove clutter.

          Show
          Parejkoj John Parejko added a comment - Please delete the ticket/ DM-7297 (singular) branch to remove clutter.
          Hide
          Permalink
          tjenness Tim Jenness added a comment -

          Looks good. Some minor comments:

          • Some cleanups required with spaces around operators (autopep8 does not sort them out) and around line breaks.
          • I have some concerns that there are many examples in the examples/ directory but I have no idea if they work and there are 3 test files in there using old style tests. That looks strange.
          • I would like some fixups in the tests that do try/except/else. Some of them should be rewritten to be use assertRaises (which would make the tests significantly more readable) and some of them shouldn't be in try blocks at all as they should never raise an exception.
          Show
          tjenness Tim Jenness added a comment - Looks good. Some minor comments: Some cleanups required with spaces around operators (autopep8 does not sort them out) and around line breaks. I have some concerns that there are many examples in the examples/ directory but I have no idea if they work and there are 3 test files in there using old style tests. That looks strange. I would like some fixups in the tests that do try/except/else. Some of them should be rewritten to be use assertRaises (which would make the tests significantly more readable) and some of them shouldn't be in try blocks at all as they should never raise an exception.

            People

            Assignee:
            mrawls Meredith Rawls
            Reporter:
            tjenness Tim Jenness
            Reviewers:
            Tim Jenness
            Watchers:
            John Parejko, Meredith Rawls, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.