Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7297

Port ip_diffim to Python 3

    XMLWordPrintable

    Details

      Attachments

        Issue Links

          Activity

          No builds found.
          tjenness Tim Jenness created issue -
          tjenness Tim Jenness made changes -
          Field Original Value New Value
          Link This issue relates to DM-6179 [ DM-6179 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14224 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14224 ] This issue links to "Page (Confluence)" [ 14224 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14224 ] This issue links to "Page (Confluence)" [ 14224 ]
          nlust Nate Lust made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14224 ] This issue links to "Page (Confluence)" [ 14224 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14224 ] This issue links to "Page (Confluence)" [ 14224 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14224 ] This issue links to "Page (Confluence)" [ 14224 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14224 ] This issue links to "Page (Confluence)" [ 14224 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14224 ] This issue links to "Page (Confluence)" [ 14224 ]
          tjenness Tim Jenness made changes -
          Link This issue blocks DM-7292 [ DM-7292 ]
          tjenness Tim Jenness made changes -
          Link This issue is blocked by DM-7289 [ DM-7289 ]
          tjenness Tim Jenness made changes -
          Link This issue is blocked by DM-7245 [ DM-7245 ]
          tjenness Tim Jenness made changes -
          Link This issue is blocked by DM-7152 [ DM-7152 ]
          tjenness Tim Jenness made changes -
          Link This issue is blocked by DM-7262 [ DM-7262 ]
          tjenness Tim Jenness made changes -
          Link This issue is blocked by DM-7303 [ DM-7303 ]
          tjenness Tim Jenness made changes -
          Link This issue is blocked by DM-7299 [ DM-7299 ]
          tjenness Tim Jenness made changes -
          Link This issue is blocked by DM-7320 [ DM-7320 ]
          nlust Nate Lust made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14224 ] This issue links to "Page (Confluence)" [ 14224 ]
          swinbank John Swinbank made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14224 ] This issue links to "Page (Confluence)" [ 14224 ]
          swinbank John Swinbank made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14224 ] This issue links to "Page (Confluence)" [ 14224 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14224 ] This issue links to "Page (Confluence)" [ 14224 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14224 ] This issue links to "Page (Confluence)" [ 14224 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14224 ] This issue links to "Page (Confluence)" [ 14224 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14224 ] This issue links to "Page (Confluence)" [ 14224 ]
          fred3m Fred Moolekamp made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14224 ] This issue links to "Page (Confluence)" [ 14224 ]
          fred3m Fred Moolekamp made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14224 ] This issue links to "Page (Confluence)" [ 14224 ]
          fred3m Fred Moolekamp made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14224 ] This issue links to "Page (Confluence)" [ 14224 ]
          fred3m Fred Moolekamp made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14224 ] This issue links to "Page (Confluence)" [ 14224 ]
          fred3m Fred Moolekamp made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14224 ] This issue links to "Page (Confluence)" [ 14224 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14224 ] This issue links to "Page (Confluence)" [ 14224 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14224 ] This issue links to "Page (Confluence)" [ 14224 ]
          Parejkoj John Parejko made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14224 ] This issue links to "Page (Confluence)" [ 14224 ]
          Parejkoj John Parejko made changes -
          Assignee John Parejko [ parejkoj ]
          mrawls Meredith Rawls made changes -
          Assignee John Parejko [ parejkoj ] Meredith Rawls [ mrawls ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14224 ] This issue links to "Page (Confluence)" [ 14224 ]
          Hide
          mrawls Meredith Rawls added a comment -

          Started working on this.

          Show
          mrawls Meredith Rawls added a comment - Started working on this.
          mrawls Meredith Rawls made changes -
          Status To Do [ 10001 ] In Progress [ 3 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14224 ] This issue links to "Page (Confluence)" [ 14224 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14224 ] This issue links to "Page (Confluence)" [ 14224 ]
          mrawls Meredith Rawls made changes -
          Team Alert Production [ 10300 ]
          mrawls Meredith Rawls made changes -
          Sprint Alert Production F16 - 9 [ 247 ]
          Parejkoj John Parejko made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14224 ] This issue links to "Page (Confluence)" [ 14224 ]
          spietrowicz Steve Pietrowicz made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14224 ] This issue links to "Page (Confluence)" [ 14224 ]
          Hide
          Parejkoj John Parejko added a comment -

          Please delete the ticket/DM-7297 (singular) branch to remove clutter.

          Show
          Parejkoj John Parejko added a comment - Please delete the ticket/ DM-7297 (singular) branch to remove clutter.
          mrawls Meredith Rawls made changes -
          Status In Progress [ 3 ] In Review [ 10004 ]
          Reviewers Tim Jenness [ tjenness ]
          Hide
          tjenness Tim Jenness added a comment -

          Looks good. Some minor comments:

          • Some cleanups required with spaces around operators (autopep8 does not sort them out) and around line breaks.
          • I have some concerns that there are many examples in the examples/ directory but I have no idea if they work and there are 3 test files in there using old style tests. That looks strange.
          • I would like some fixups in the tests that do try/except/else. Some of them should be rewritten to be use assertRaises (which would make the tests significantly more readable) and some of them shouldn't be in try blocks at all as they should never raise an exception.
          Show
          tjenness Tim Jenness added a comment - Looks good. Some minor comments: Some cleanups required with spaces around operators (autopep8 does not sort them out) and around line breaks. I have some concerns that there are many examples in the examples/ directory but I have no idea if they work and there are 3 test files in there using old style tests. That looks strange. I would like some fixups in the tests that do try/except/else. Some of them should be rewritten to be use assertRaises (which would make the tests significantly more readable) and some of them shouldn't be in try blocks at all as they should never raise an exception.
          tjenness Tim Jenness made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          mrawls Meredith Rawls made changes -
          Link This issue relates to DM-7684 [ DM-7684 ]
          mrawls Meredith Rawls made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]
          mrawls Meredith Rawls made changes -
          Story Points 2
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14224 ] This issue links to "Page (Confluence)" [ 14224 ]
          rowen Russell Owen made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14224 ] This issue links to "Page (Confluence)" [ 14224 ]
          rowen Russell Owen made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14224 ] This issue links to "Page (Confluence)" [ 14224 ]
          krughoff Simon Krughoff made changes -
          Epic Link DM-7362 [ 26448 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14224 ] This issue links to "Page (Confluence)" [ 14224 ]

            People

            Assignee:
            mrawls Meredith Rawls
            Reporter:
            tjenness Tim Jenness
            Reviewers:
            Tim Jenness
            Watchers:
            John Parejko, Meredith Rawls, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.