Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7297

Port ip_diffim to Python 3

    XMLWordPrintable

Details

    Attachments

      Issue Links

        Activity

          Started working on this.

          mrawls Meredith Rawls added a comment - Started working on this.

          Please delete the ticket/DM-7297 (singular) branch to remove clutter.

          Parejkoj John Parejko added a comment - Please delete the ticket/ DM-7297 (singular) branch to remove clutter.
          tjenness Tim Jenness added a comment -

          Looks good. Some minor comments:

          • Some cleanups required with spaces around operators (autopep8 does not sort them out) and around line breaks.
          • I have some concerns that there are many examples in the examples/ directory but I have no idea if they work and there are 3 test files in there using old style tests. That looks strange.
          • I would like some fixups in the tests that do try/except/else. Some of them should be rewritten to be use assertRaises (which would make the tests significantly more readable) and some of them shouldn't be in try blocks at all as they should never raise an exception.
          tjenness Tim Jenness added a comment - Looks good. Some minor comments: Some cleanups required with spaces around operators (autopep8 does not sort them out) and around line breaks. I have some concerns that there are many examples in the examples/ directory but I have no idea if they work and there are 3 test files in there using old style tests. That looks strange. I would like some fixups in the tests that do try/except/else. Some of them should be rewritten to be use assertRaises (which would make the tests significantly more readable) and some of them shouldn't be in try blocks at all as they should never raise an exception.

          People

            mrawls Meredith Rawls
            tjenness Tim Jenness
            Tim Jenness
            John Parejko, Meredith Rawls, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Jenkins

                No builds found.