Details

    • Templates:
    • Story Points:
      1
    • Sprint:
      Alert Production F16 - 9, Alert Production F16 - 11c
    • Team:
      Alert Production

      Issue Links

        Activity

        Hide
        Parejkoj John Parejko added a comment -

        Doing this to finish py3 porting.

        Show
        Parejkoj John Parejko added a comment - Doing this to finish py3 porting.
        Hide
        Parejkoj John Parejko added a comment -

        Meredith: I'm going to give you a couple of the obs packages to review. Should be pretty simple: the usual py3 porting stuff, plus a million pep8 cleanups.

        Show
        Parejkoj John Parejko added a comment - Meredith: I'm going to give you a couple of the obs packages to review. Should be pretty simple: the usual py3 porting stuff, plus a million pep8 cleanups.
        Hide
        Parejkoj John Parejko added a comment -

        Passed jenkins on py2/3 w/lsst_py3: https://ci.lsst.codes/job/stack-os-matrix/18007

        Show
        Parejkoj John Parejko added a comment - Passed jenkins on py2/3 w/lsst_py3: https://ci.lsst.codes/job/stack-os-matrix/18007
        Hide
        mrawls Meredith Rawls added a comment -

        Looks fine, just a couple minor formatting things to comply with our python style guide. Most notably the part about "keyword assignment operators SHOULD be surrounded by a space when statements appear on multiple lines" (that is a section header from the style guide).

        Show
        mrawls Meredith Rawls added a comment - Looks fine, just a couple minor formatting things to comply with our python style guide. Most notably the part about "keyword assignment operators SHOULD be surrounded by a space when statements appear on multiple lines" (that is a section header from the style guide).
        Hide
        Parejkoj John Parejko added a comment -

        Thanks for the review. Merged, including lsst_py3.

        Show
        Parejkoj John Parejko added a comment - Thanks for the review. Merged, including lsst_py3.
        Hide
        Parejkoj John Parejko added a comment -

        Oops. Wrong button. Merged and done.

        Show
        Parejkoj John Parejko added a comment - Oops. Wrong button. Merged and done.

          People

          • Assignee:
            Parejkoj John Parejko
            Reporter:
            tjenness Tim Jenness
            Reviewers:
            Meredith Rawls
            Watchers:
            John Parejko, Meredith Rawls, Tim Jenness
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Agile