Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7307

Port obs_decam to Python 3

    Details

      Attachments

        Issue Links

          Activity

          Hide
          Parejkoj John Parejko added a comment -

          1. testButler.py was failing because the linearizer pickle files were written with py2 and didn't have an encoding specified (small fix in daf_persistence, which I've pushed, and we'll have to see if it breaks anything else once I get the other obs_decam problem fixed).

          2. testProcessCcd is failing 3 tests related to the output repository. I'm still investigating htis one.

          Show
          Parejkoj John Parejko added a comment - 1. testButler.py was failing because the linearizer pickle files were written with py2 and didn't have an encoding specified (small fix in daf_persistence, which I've pushed, and we'll have to see if it breaks anything else once I get the other obs_decam problem fixed). 2. testProcessCcd is failing 3 tests related to the output repository. I'm still investigating htis one.
          Hide
          Parejkoj John Parejko added a comment -

          2. is fixed in python2 and 3: was an integer->float division bug.

          1. is not fixed, because "encoding" is a python3-only pickle.load() parameter. I'm going to have to find a different way.

          Show
          Parejkoj John Parejko added a comment - 2. is fixed in python2 and 3: was an integer->float division bug. 1. is not fixed, because "encoding" is a python3-only pickle.load() parameter. I'm going to have to find a different way.
          Hide
          Parejkoj John Parejko added a comment -

          Ok, both problems now appear to be actually fixed. Please review.

          Show
          Parejkoj John Parejko added a comment - Ok, both problems now appear to be actually fixed. Please review.
          Hide
          Parejkoj John Parejko added a comment -
          Show
          Parejkoj John Parejko added a comment - Jenkins passed: https://ci.lsst.codes/job/stack-os-matrix/18045/
          Hide
          Parejkoj John Parejko added a comment -

          Thanks for the quick review, Meredith, and the suggestion to clarify a few changes. Merged and done, including lsst_py3.

          Show
          Parejkoj John Parejko added a comment - Thanks for the quick review, Meredith, and the suggestion to clarify a few changes. Merged and done, including lsst_py3.

            People

            • Assignee:
              Parejkoj John Parejko
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Meredith Rawls
              Watchers:
              John Parejko, Meredith Rawls, Tim Jenness
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel