Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7307

Port obs_decam to Python 3

    XMLWordPrintable

    Details

      Attachments

        Issue Links

          Activity

          No builds found.
          tjenness Tim Jenness created issue -
          tjenness Tim Jenness made changes -
          Field Original Value New Value
          Link This issue relates to DM-6179 [ DM-6179 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14241 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14241 ] This issue links to "Page (Confluence)" [ 14241 ]
          nlust Nate Lust made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14241 ] This issue links to "Page (Confluence)" [ 14241 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14241 ] This issue links to "Page (Confluence)" [ 14241 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14241 ] This issue links to "Page (Confluence)" [ 14241 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14241 ] This issue links to "Page (Confluence)" [ 14241 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14241 ] This issue links to "Page (Confluence)" [ 14241 ]
          tjenness Tim Jenness made changes -
          Link This issue blocks DM-7328 [ DM-7328 ]
          tjenness Tim Jenness made changes -
          Link This issue is blocked by DM-7289 [ DM-7289 ]
          tjenness Tim Jenness made changes -
          Link This issue is blocked by DM-7247 [ DM-7247 ]
          tjenness Tim Jenness made changes -
          Link This issue is blocked by DM-7292 [ DM-7292 ]
          tjenness Tim Jenness made changes -
          Link This issue is blocked by DM-7152 [ DM-7152 ]
          tjenness Tim Jenness made changes -
          Link This issue is blocked by DM-7262 [ DM-7262 ]
          tjenness Tim Jenness made changes -
          Link This issue is blocked by DM-7296 [ DM-7296 ]
          tjenness Tim Jenness made changes -
          Link This issue is blocked by DM-7133 [ DM-7133 ]
          nlust Nate Lust made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14241 ] This issue links to "Page (Confluence)" [ 14241 ]
          tjenness Tim Jenness made changes -
          Link This issue is blocked by DM-7387 [ DM-7387 ]
          swinbank John Swinbank made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14241 ] This issue links to "Page (Confluence)" [ 14241 ]
          swinbank John Swinbank made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14241 ] This issue links to "Page (Confluence)" [ 14241 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14241 ] This issue links to "Page (Confluence)" [ 14241 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14241 ] This issue links to "Page (Confluence)" [ 14241 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14241 ] This issue links to "Page (Confluence)" [ 14241 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14241 ] This issue links to "Page (Confluence)" [ 14241 ]
          fred3m Fred Moolekamp made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14241 ] This issue links to "Page (Confluence)" [ 14241 ]
          fred3m Fred Moolekamp made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14241 ] This issue links to "Page (Confluence)" [ 14241 ]
          fred3m Fred Moolekamp made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14241 ] This issue links to "Page (Confluence)" [ 14241 ]
          fred3m Fred Moolekamp made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14241 ] This issue links to "Page (Confluence)" [ 14241 ]
          fred3m Fred Moolekamp made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14241 ] This issue links to "Page (Confluence)" [ 14241 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14241 ] This issue links to "Page (Confluence)" [ 14241 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14241 ] This issue links to "Page (Confluence)" [ 14241 ]
          Parejkoj John Parejko made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14241 ] This issue links to "Page (Confluence)" [ 14241 ]
          Parejkoj John Parejko made changes -
          Assignee John Parejko [ parejkoj ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14241 ] This issue links to "Page (Confluence)" [ 14241 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14241 ] This issue links to "Page (Confluence)" [ 14241 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14241 ] This issue links to "Page (Confluence)" [ 14241 ]
          Parejkoj John Parejko made changes -
          Sprint Alert Production F16 - 9 [ 247 ]
          Parejkoj John Parejko made changes -
          Story Points 1
          Parejkoj John Parejko made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14241 ] This issue links to "Page (Confluence)" [ 14241 ]
          spietrowicz Steve Pietrowicz made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14241 ] This issue links to "Page (Confluence)" [ 14241 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14241 ] This issue links to "Page (Confluence)" [ 14241 ]
          rowen Russell Owen made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14241 ] This issue links to "Page (Confluence)" [ 14241 ]
          rowen Russell Owen made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14241 ] This issue links to "Page (Confluence)" [ 14241 ]
          Hide
          Parejkoj John Parejko added a comment -

          Started while pipe_tasks is in progress, so I can test it with obs_base.

          Show
          Parejkoj John Parejko added a comment - Started while pipe_tasks is in progress, so I can test it with obs_base.
          Parejkoj John Parejko made changes -
          Status To Do [ 10001 ] In Progress [ 3 ]
          Parejkoj John Parejko made changes -
          Link This issue relates to DM-7909 [ DM-7909 ]
          Parejkoj John Parejko made changes -
          Sprint Alert Production F16 - 9 [ 247 ] Alert Production F16 - 9, Alert Production F16 - 11c [ 247, 296 ]
          Hide
          Parejkoj John Parejko added a comment -

          Meredith: I'm going to give you a couple of the obs packages to review. Should be pretty simple: the usual py3 porting stuff, plus a million pep8 cleanups.

          Show
          Parejkoj John Parejko added a comment - Meredith: I'm going to give you a couple of the obs packages to review. Should be pretty simple: the usual py3 porting stuff, plus a million pep8 cleanups.
          Parejkoj John Parejko made changes -
          Status In Progress [ 3 ] In Review [ 10004 ]
          Reviewers Meredith Rawls [ mrawls ]
          Hide
          Parejkoj John Parejko added a comment -

          Looks like this one fails jenkins on py3. Going to have to dig into that.

          https://ci.lsst.codes/job/stack-os-matrix/18008/

          Show
          Parejkoj John Parejko added a comment - Looks like this one fails jenkins on py3. Going to have to dig into that. https://ci.lsst.codes/job/stack-os-matrix/18008/
          Hide
          Parejkoj John Parejko added a comment -

          I'm guessing those failures are related to the ones Meredith Rawls saw in pipe_tasks due to pex_config str stuff. I'll see if I can debug it tonight.

          Show
          Parejkoj John Parejko added a comment - I'm guessing those failures are related to the ones Meredith Rawls saw in pipe_tasks due to pex_config str stuff. I'll see if I can debug it tonight.
          Hide
          mrawls Meredith Rawls added a comment -

          Can you clarify what is failing, because that Jenkins link looks to me like everything passed? My pex_config string stuff turned out to be resolved by making sure I didn't have any from builtins import str lines in the py3-ported code, fwiw.

          Show
          mrawls Meredith Rawls added a comment - Can you clarify what is failing, because that Jenkins link looks to me like everything passed? My pex_config string stuff turned out to be resolved by making sure I didn't have any from builtins import str lines in the py3-ported code, fwiw.
          Hide
          Parejkoj John Parejko added a comment -

          1. testButler.py was failing because the linearizer pickle files were written with py2 and didn't have an encoding specified (small fix in daf_persistence, which I've pushed, and we'll have to see if it breaks anything else once I get the other obs_decam problem fixed).

          2. testProcessCcd is failing 3 tests related to the output repository. I'm still investigating htis one.

          Show
          Parejkoj John Parejko added a comment - 1. testButler.py was failing because the linearizer pickle files were written with py2 and didn't have an encoding specified (small fix in daf_persistence, which I've pushed, and we'll have to see if it breaks anything else once I get the other obs_decam problem fixed). 2. testProcessCcd is failing 3 tests related to the output repository. I'm still investigating htis one.
          Parejkoj John Parejko made changes -
          Link This issue relates to DM-8219 [ DM-8219 ]
          Hide
          Parejkoj John Parejko added a comment -

          2. is fixed in python2 and 3: was an integer->float division bug.

          1. is not fixed, because "encoding" is a python3-only pickle.load() parameter. I'm going to have to find a different way.

          Show
          Parejkoj John Parejko added a comment - 2. is fixed in python2 and 3: was an integer->float division bug. 1. is not fixed, because "encoding" is a python3-only pickle.load() parameter. I'm going to have to find a different way.
          Parejkoj John Parejko made changes -
          Link This issue relates to DM-8220 [ DM-8220 ]
          Hide
          Parejkoj John Parejko added a comment -

          Ok, both problems now appear to be actually fixed. Please review.

          Show
          Parejkoj John Parejko added a comment - Ok, both problems now appear to be actually fixed. Please review.
          Hide
          Parejkoj John Parejko added a comment -
          Show
          Parejkoj John Parejko added a comment - Jenkins passed: https://ci.lsst.codes/job/stack-os-matrix/18045/
          mrawls Meredith Rawls made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          Hide
          Parejkoj John Parejko added a comment -

          Thanks for the quick review, Meredith, and the suggestion to clarify a few changes. Merged and done, including lsst_py3.

          Show
          Parejkoj John Parejko added a comment - Thanks for the quick review, Meredith, and the suggestion to clarify a few changes. Merged and done, including lsst_py3.
          Parejkoj John Parejko made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]
          krughoff Simon Krughoff made changes -
          Team Alert Production [ 10300 ]
          tjenness Tim Jenness made changes -
          Remote Link This issue links to "Page (Confluence)" [ 14241 ] This issue links to "Page (Confluence)" [ 14241 ]
          krughoff Simon Krughoff made changes -
          Epic Link DM-7362 [ 26448 ]

            People

            Assignee:
            Parejkoj John Parejko
            Reporter:
            tjenness Tim Jenness
            Reviewers:
            Meredith Rawls
            Watchers:
            John Parejko, Meredith Rawls, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.